Skip to content

Conversation

@nwithan8
Copy link
Contributor

@nwithan8 nwithan8 commented Aug 19, 2022

Description

  • Copy EndShipper to main namespace
  • Mark beta EndShipper as deprecated
  • Update unit tests

Testing

  • Unit tests for EndShipper updated and passing

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

- Mark beta EndShipper as deprecated
- Update unit tests - fail until endpoint is live
- Record EndShipper cassettes now that endpoint is live
@nwithan8 nwithan8 marked this pull request as ready for review August 24, 2022 21:16
@nwithan8 nwithan8 requested a review from a team August 24, 2022 21:16
Copy link
Member

@Justintime50 Justintime50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update the require_once line in the /lib/easypost.php file for users that manually require our library, I'm not seeing that here.

@nwithan8
Copy link
Contributor Author

We need to update the require_once line in the /lib/easypost.php file for users that manually require our library, I'm not seeing that here.

Thanks, I knew there was something along those lines, couldn't remember what.

@Justintime50
Copy link
Member

Thanks, I knew there was something along those lines, couldn't remember what.

May be good to ask next time then 😅

@nwithan8 nwithan8 merged commit 5f2c71a into master Aug 24, 2022
@nwithan8 nwithan8 deleted the endshipper branch August 24, 2022 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants