Skip to content

Commit 40f96d2

Browse files
authored
Merge pull request #212 from EasyPost/fix_extra_imports
fix: extra imports and add regression test
2 parents a767cc5 + 434bd79 commit 40f96d2

File tree

3 files changed

+63
-42
lines changed

3 files changed

+63
-42
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# CHANGELOG
22

3+
## v5.5.1 (2022-08-20)
4+
5+
- Removes some extra imports that no longer exist causing errors when importing this library. Adds a regression test to protect against this in the future.
6+
37
## v5.5.0 (2022-08-02)
48

59
- Adds Carbon Offset support

lib/easypost.php

Lines changed: 40 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?php
22

3-
// Require this file if you're not using composer's vendor/autoload
3+
// `require` this file if you're not using composer's vendor/autoload
44

55
// Required PHP extensions
66
if (!function_exists('curl_init')) {
@@ -11,48 +11,46 @@
1111
}
1212

1313
// Config and Utilities
14-
require(dirname(__FILE__) . '/EasyPost/EasyPost.php');
15-
require(dirname(__FILE__) . '/EasyPost/Util.php');
16-
require(dirname(__FILE__) . '/EasyPost/Error.php');
14+
require_once(dirname(__FILE__) . '/EasyPost/EasyPost.php');
15+
require_once(dirname(__FILE__) . '/EasyPost/Util.php');
16+
require_once(dirname(__FILE__) . '/EasyPost/Error.php');
1717

1818
// Guts
19-
require(dirname(__FILE__) . '/EasyPost/EasyPostObject.php');
20-
require(dirname(__FILE__) . '/EasyPost/EasypostResource.php');
21-
require(dirname(__FILE__) . '/EasyPost/Requestor.php');
19+
require_once(dirname(__FILE__) . '/EasyPost/EasyPostObject.php');
20+
require_once(dirname(__FILE__) . '/EasyPost/EasypostResource.php');
21+
require_once(dirname(__FILE__) . '/EasyPost/Requestor.php');
2222

2323
// API Resources
24-
require(dirname(__FILE__) . '/EasyPost/Address.php');
25-
require(dirname(__FILE__) . '/EasyPost/Batch.php');
26-
require(dirname(__FILE__) . '/EasyPost/Brand.php');
27-
require(dirname(__FILE__) . '/EasyPost/CarbonOffset.php');
28-
require(dirname(__FILE__) . '/EasyPost/CarrierAccount.php');
29-
require(dirname(__FILE__) . '/EasyPost/CarrierDetail.php');
30-
require(dirname(__FILE__) . '/EasyPost/CreditCard.php');
31-
require(dirname(__FILE__) . '/EasyPost/CustomsInfo.php');
32-
require(dirname(__FILE__) . '/EasyPost/CustomsItem.php');
33-
require(dirname(__FILE__) . '/EasyPost/Beta/EndShipper.php');
34-
require(dirname(__FILE__) . '/EasyPost/Event.php');
35-
require(dirname(__FILE__) . '/EasyPost/Fee.php');
36-
require(dirname(__FILE__) . '/EasyPost/FieldError.php');
37-
require(dirname(__FILE__) . '/EasyPost/Insurance.php');
38-
require(dirname(__FILE__) . '/EasyPost/Message.php');
39-
require(dirname(__FILE__) . '/EasyPost/Order.php');
40-
require(dirname(__FILE__) . '/EasyPost/Parcel.php');
41-
require(dirname(__FILE__) . '/EasyPost/PaymentMethod.php');
42-
require(dirname(__FILE__) . '/EasyPost/Pickup.php');
43-
require(dirname(__FILE__) . '/EasyPost/PickupRate.php');
44-
require(dirname(__FILE__) . '/EasyPost/PostageLabel.php');
45-
require(dirname(__FILE__) . '/EasyPost/Rate.php');
46-
require(dirname(__FILE__) . '/EasyPost/Refund.php');
47-
require(dirname(__FILE__) . '/EasyPost/Report.php');
48-
require(dirname(__FILE__) . '/EasyPost/ScanForm.php');
49-
require(dirname(__FILE__) . '/EasyPost/Shipment.php');
50-
require(dirname(__FILE__) . '/EasyPost/TaxIdentifier.php');
51-
require(dirname(__FILE__) . '/EasyPost/Tracker.php');
52-
require(dirname(__FILE__) . '/EasyPost/TrackingDetail.php');
53-
require(dirname(__FILE__) . '/EasyPost/TrackingLocation.php');
54-
require(dirname(__FILE__) . '/EasyPost/User.php');
55-
require(dirname(__FILE__) . '/EasyPost/Verification.php');
56-
require(dirname(__FILE__) . '/EasyPost/VerificationDetails.php');
57-
require(dirname(__FILE__) . '/EasyPost/Verifications.php');
58-
require(dirname(__FILE__) . '/EasyPost/Webhook.php');
24+
require_once(dirname(__FILE__) . '/EasyPost/Address.php');
25+
require_once(dirname(__FILE__) . '/EasyPost/Batch.php');
26+
require_once(dirname(__FILE__) . '/EasyPost/Brand.php');
27+
require_once(dirname(__FILE__) . '/EasyPost/CarbonOffset.php');
28+
require_once(dirname(__FILE__) . '/EasyPost/CarrierAccount.php');
29+
require_once(dirname(__FILE__) . '/EasyPost/CarrierDetail.php');
30+
require_once(dirname(__FILE__) . '/EasyPost/CustomsInfo.php');
31+
require_once(dirname(__FILE__) . '/EasyPost/CustomsItem.php');
32+
require_once(dirname(__FILE__) . '/EasyPost/Beta/EndShipper.php');
33+
require_once(dirname(__FILE__) . '/EasyPost/Event.php');
34+
require_once(dirname(__FILE__) . '/EasyPost/Fee.php');
35+
require_once(dirname(__FILE__) . '/EasyPost/FieldError.php');
36+
require_once(dirname(__FILE__) . '/EasyPost/Insurance.php');
37+
require_once(dirname(__FILE__) . '/EasyPost/Message.php');
38+
require_once(dirname(__FILE__) . '/EasyPost/Order.php');
39+
require_once(dirname(__FILE__) . '/EasyPost/Parcel.php');
40+
require_once(dirname(__FILE__) . '/EasyPost/Pickup.php');
41+
require_once(dirname(__FILE__) . '/EasyPost/PickupRate.php');
42+
require_once(dirname(__FILE__) . '/EasyPost/PostageLabel.php');
43+
require_once(dirname(__FILE__) . '/EasyPost/Rate.php');
44+
require_once(dirname(__FILE__) . '/EasyPost/Refund.php');
45+
require_once(dirname(__FILE__) . '/EasyPost/Report.php');
46+
require_once(dirname(__FILE__) . '/EasyPost/ScanForm.php');
47+
require_once(dirname(__FILE__) . '/EasyPost/Shipment.php');
48+
require_once(dirname(__FILE__) . '/EasyPost/TaxIdentifier.php');
49+
require_once(dirname(__FILE__) . '/EasyPost/Tracker.php');
50+
require_once(dirname(__FILE__) . '/EasyPost/TrackingDetail.php');
51+
require_once(dirname(__FILE__) . '/EasyPost/TrackingLocation.php');
52+
require_once(dirname(__FILE__) . '/EasyPost/User.php');
53+
require_once(dirname(__FILE__) . '/EasyPost/Verification.php');
54+
require_once(dirname(__FILE__) . '/EasyPost/VerificationDetails.php');
55+
require_once(dirname(__FILE__) . '/EasyPost/Verifications.php');
56+
require_once(dirname(__FILE__) . '/EasyPost/Webhook.php');

test/EasyPost/RequireTest.php

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
<?php
2+
3+
namespace EasyPost\Test;
4+
5+
require 'lib/easypost.php';
6+
7+
class RequireTest extends \PHPUnit\Framework\TestCase
8+
{
9+
/**
10+
* Tests that no errors are thrown when we import the library without using the autoloader.
11+
* Things like missing or extra imports should be caught by this. The actual assertion here
12+
* doesn't matter, only that an import/require error isn't thrown.
13+
*/
14+
public function testRequireLibrary()
15+
{
16+
$apiBase = \EasyPost\EasyPost::getApiBase();
17+
$this->assertEquals('https://api.easypost.com/v2', $apiBase);
18+
}
19+
}

0 commit comments

Comments
 (0)