Skip to content

Commit 3053367

Browse files
authored
Merge pull request #636 from EasyPost/fix_releasing
fix: releasing workflow
2 parents 6844c26 + c1fd3b8 commit 3053367

File tree

3 files changed

+11
-10
lines changed

3 files changed

+11
-10
lines changed

.github/workflows/manual_release_prep.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,11 @@ jobs:
1515
uses: actions/setup-dotnet@v5
1616
with:
1717
dotnet-version: |
18-
5.x.x
1918
6.x.x
2019
7.x.x
2120
8.x.x
2221
9.x.x
22+
10.x.x
2323
2424
- name: Setup Nuget
2525
uses: NuGet/setup-nuget@v2
@@ -63,10 +63,10 @@ jobs:
6363

6464
- name: Build and Sign NuGet package
6565
run: |
66-
call scripts\win\build_release_nuget.bat EasyPost EasyPostNETStrongNameSigning.snk "${{ secrets.SM_CODE_SIGNING_CERT_SHA1_HASH }}" Release
66+
call scripts\win\build_release_nuget.bat EasyPost EasyPostNETStrongNameSigning.snk "${{ secrets.SM_CODE_SIGNING_CERT_SHA1_HASH }}" "${{ secrets.SM_CODE_SIGNING_CERT_SHA256_HASH }}" Release
6767
shell: cmd
6868

6969
- name: Upload NuGet package to Action output
7070
uses: actions/upload-artifact@v4
7171
with:
72-
path: "*.nupkg"
72+
path: '*.nupkg'

.github/workflows/release.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,11 @@ jobs:
1616
uses: actions/setup-dotnet@v5
1717
with:
1818
dotnet-version: |
19-
5.x.x
2019
6.x.x
2120
7.x.x
2221
8.x.x
2322
9.x.x
23+
10.x.x
2424
2525
- name: Setup Nuget
2626
uses: NuGet/setup-nuget@v2
@@ -64,7 +64,7 @@ jobs:
6464

6565
- name: Build and Sign NuGet package
6666
run: |
67-
call scripts\win\build_release_nuget.bat EasyPost EasyPostNETStrongNameSigning.snk "${{ secrets.SM_CODE_SIGNING_CERT_SHA1_HASH }}" Release
67+
call scripts\win\build_release_nuget.bat EasyPost EasyPostNETStrongNameSigning.snk "${{ secrets.SM_CODE_SIGNING_CERT_SHA1_HASH }}" "${{ secrets.SM_CODE_SIGNING_CERT_SHA256_HASH }}" Release
6868
shell: cmd
6969

7070
- name: Publish to NuGet
@@ -73,5 +73,5 @@ jobs:
7373
- name: Upload NuGet package to release
7474
uses: AButler/upload-release-assets@v3.0.1
7575
with:
76-
files: "*.nupkg"
76+
files: '*.nupkg'
7777
repo-token: ${{ secrets.GITHUB_TOKEN }}

scripts/win/build_release_nuget.bat

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,9 @@
1111
:: Parse command line arguments
1212
SET projectName=%1
1313
SET strongNameCertFile=%2
14-
SET authCertFingerprint=%3
15-
SET buildMode=%4
14+
SET authCertSha1Fingerprint=%3
15+
SET authCertSha256Fingerprint=%4
16+
SET buildMode=%5
1617

1718
:: Delete old files
1819
CALL "scripts\win\delete_old_assemblies.bat"
@@ -24,13 +25,13 @@ CALL "scripts\win\build_project.bat" %buildMode% || GOTO :commandFailed
2425
CALL "scripts\win\strong_name_dlls.bat" %strongNameCertFile% || GOTO :commandFailed
2526

2627
:: Sign the DLLs for authenticity
27-
CALL "scripts\win\sign_dlls.bat" %authCertFingerprint% || GOTO :commandFailed
28+
CALL "scripts\win\sign_dlls.bat" %authCertSha1Fingerprint% || GOTO :commandFailed
2829

2930
:: Package the DLLs in a NuGet package (will fail if DLLs are missing)
3031
CALL "scripts\win\pack_nuget.bat" %projectName% || GOTO :commandFailed
3132

3233
:: Sign the NuGet package for authenticity
33-
CALL "scripts\win\sign_nuget.bat" %authCertFingerprint% || GOTO :commandFailed
34+
CALL "scripts\win\sign_nuget.bat" %authCertSha256Fingerprint% || GOTO :commandFailed
3435
SET nugetFileName=
3536
FOR /R %%F IN (*.nupkg) DO (
3637
SET nugetFileName="%%F"

0 commit comments

Comments
 (0)