Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename 'site ssl' to 'site ssl-verify' #235

Open
kirtangajjar opened this issue Nov 27, 2018 · 0 comments
Open

Rename 'site ssl' to 'site ssl-verify' #235

kirtangajjar opened this issue Nov 27, 2018 · 0 comments
Assignees

Comments

@kirtangajjar
Copy link
Contributor

ee site ssl command is causing confusion among new v4 users. They either assume it will add SSL to a non-SSL site or they think it will be required to run every time after any SSL site creation.

Hence to clarify what ee site ssl does, it is better if we rename it to ee site ssl-verify. If the current command does both verify SSL when using the DNS method and renew if it's present, we can create another command ee site ssl-renew and call the same function internally.

Also, it would be great if we would be able to track if DNS challenge verification is pending on a site. We can add this info in site_meta and only allow ee site ssl-verify if DNS verification is pending.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants