Fix two typos #147
Merged
Fix two typos #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes two identical typos in the BiorthBasis.cc file where incorrect vector indices were being used in coordinate transformation calculations. The changes correct the use of v[4] to v[6] in the potx and poty calculations within two crt_eval() methods for 2D disk implementations.
- Corrects vector index from
v[4]tov[6]in potential calculations - Applies the same fix to two separate methods in the same file
michael-petersen
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found these typos in 2d disk
crt_eval()methods while working on PR #146. Might as well correct those in main, too.I doubt they affected anyone's work flow, since I'm the only one using
FlatDiskorCBDiskas far as I know, and I didn't notice these while usingpyEXP.