Published recipes use deprecated `fx_variables` option in preprocessors

[schlunma]

Due to recent changes in ESMValCore (ESMValGroup/ESMValCore#1609 and co.) we need to adapt some recipes because the usage of the option fx_variables in preprocessors is deprecated.

These can be fixed by replacing fx_variables with supplementary_variables as described here.

• examples/recipe_python.yml (fixed in Update Python example recipe #3119)
• clouds/recipe_lauer22jclim_fig8_dyn.yml (fixed in Removed fx_variables in recipe_mpqb_xch4 and recipe_lauer22jclim_fig8 #3117)
• recipe_cox18nature.yml
• recipe_tcr.yml
• recipe_ecs_constraints.yml
• recipe_impact.yml (fixed in Let recipe_impact.yml write a CSV file that can directly be used in C4I portal #2258)
• recipe_meehl20sciadv.yml
• recipe_ecs.yml
• recipe_wenzel14jgr.yml (fixed in Remove "fx_variable" from recipe_wenzel14jgr.yml #3212)
• recipe_schlund20esd.yml
• schlund20jgr/recipe_schlund20jgr_gpp_abs_rcp85.yml
• schlund20jgr/recipe_schlund20jgr_gpp_change_rcp85.yml
• monitor/recipe_monitor.yml
• monitor/recipe_monitor_with_refs.yml
• mpqb/recipe_mpqb_xch4.yml (fixed in Removed fx_variables in recipe_mpqb_xch4 and recipe_lauer22jclim_fig8 #3117)
• recipe_sea_surface_salinity.yml
• recipe_tebaldi21esd.yml (fixed in Remove "fx_variable" from recipe_tebaldi21esd.yml #3211)
• ipccwg1ar5ch9/recipe_flato13ipcc_figures_938_941_cmip3.yml (this and below fixed in Remove fx_variables from ipccwg1ar5ch9 recipes #3215)
• ipccwg1ar5ch9/recipe_weigel21gmd_figures_13_16.yml
• ipccwg1ar5ch9/recipe_flato13ipcc_figures_938_941_cmip6.yml

[schlunma]

@ESMValGroup/esmvaltool-coreteam Feel free to update this list if you encounter more recipes that need updates.

[bouweandela]

The dataset name and version number needs to be updated for recipes using obs4MIPs datasets: #2974

[valeriupredoi]

the issue with collins and sftgif should not be an issue - mask_landseaice doesn't explicitly need an fx/supplementary variable - it should automatically look for sftgif and the mocker recipe_load test that fails and @schlunma links should just spit a warning, not an outright error

[schlunma]

Yeah, I will remove them again from the list and only add recipes where we confirmed that they stopped working. I thought we can trust that automated test 🥲

[valeriupredoi]

the test can be trusted (if you talking about the GA test) - the reasons it fails are all upon us 😆 Do you want to try and run those collins et al recipes - like actual runs, as you suggested, Manu? Using a Core-dev env just like the test, but where data is available, if they pass it means it's some mocking issue like we've had before, if they fail then it's some Bouweing issue like we've had before 👿

[schlunma]

We will test the recipes soon anyway, so I'll wait until that (don't want to waste resources on these huge recipes 😄 )

[valeriupredoi]

We will test the recipes soon anyway, so I'll wait until that (don't want to waste resources on these huge recipes smile )

such an Ursula von der Leyen-like answer 🥇

[remi-kazeroni]

We will test the recipes soon anyway, so I'll wait until that (don't want to waste resources on these huge recipes 😄 )

Indeed, this is probably our most resource-intensive recipe and only runs on 512GB nodes at DKRZ... See https://esmvaltool.dkrz.de/shared/esmvaltool/v2.7.0/debug.html

[schlunma]

Partly addressed by #3064

[valeriupredoi]

well Collins13 is fixed now - I mean, it's still a memory guzzler, but at least Manu and Remi ran it - any more of those recipes need fixing?

[remi-kazeroni]

All the recipes not yet updated will continue to run fine with v2.8. fx_variables was set to deprecation in ESMValGroup/ESMValCore#1609 but we discussed there already that is still supported in v2.8. Nevertheless, it would be better, if possible, to remove it from our recipes so that we don't show "bad" examples. At the latest, this will have to be finished before v2.9. I'm sure the maintainer of examples/recipe_python.yml would take care of that one next Monday, right @schlunma? 😉