-
Notifications
You must be signed in to change notification settings - Fork 44
Update notebook so it uses supplementaries instead of ancillaries #1945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1945 +/- ##
=======================================
Coverage 92.64% 92.64%
=======================================
Files 236 236
Lines 12402 12402
=======================================
Hits 11490 11490
Misses 912 912 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
valeriupredoi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cheers @bouweandela = @Peter9192 will you give it a final look and merge, please, mate? 🍺
Peter9192
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, and It works fine. Just a small comment on one more variable name
schlunma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I re-ran all the notebooks, everything works well now 🚀
Description
Update notebooks/loading-and-processing-data.ipynb so it uses
supplementariesinstead ofancillaries.Fix the issue reported in #1924 (comment).
Link to documentation: https://esmvaltool--1945.org.readthedocs.build/projects/ESMValCore/en/1945/notebooks/loading-and-processing-data.html
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: