Skip to content

Conversation

@bouweandela
Copy link
Member

@bouweandela bouweandela commented Feb 27, 2023

Description

Update notebooks/loading-and-processing-data.ipynb so it uses supplementaries instead of ancillaries.

Fix the issue reported in #1924 (comment).

Link to documentation: https://esmvaltool--1945.org.readthedocs.build/projects/ESMValCore/en/1945/notebooks/loading-and-processing-data.html


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@bouweandela bouweandela added documentation Improvements or additions to documentation api Notebook API labels Feb 27, 2023
@bouweandela bouweandela added this to the v2.8.0 milestone Feb 27, 2023
@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Merging #1945 (5f62dd9) into main (40e00e8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1945   +/-   ##
=======================================
  Coverage   92.64%   92.64%           
=======================================
  Files         236      236           
  Lines       12402    12402           
=======================================
  Hits        11490    11490           
  Misses        912      912           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bouweandela bouweandela marked this pull request as ready for review February 27, 2023 16:36
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers @bouweandela = @Peter9192 will you give it a final look and merge, please, mate? 🍺

Copy link
Contributor

@Peter9192 Peter9192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, and It works fine. Just a small comment on one more variable name

Copy link
Contributor

@schlunma schlunma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I re-ran all the notebooks, everything works well now 🚀

@remi-kazeroni remi-kazeroni merged commit 30cfba4 into main Mar 1, 2023
@remi-kazeroni remi-kazeroni deleted the use-supplementaries-in-notebook branch March 1, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Notebook API documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants