Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some variables initialized in SoilHydrologyInitTimeConstMod are not time-constant #575

Closed
billsacks opened this issue Nov 27, 2018 · 0 comments
Closed

Some variables initialized in SoilHydrologyInitTimeConstMod are not time-constant #575

billsacks opened this issue Nov 27, 2018 · 0 comments
Assignees
@negin513
Labels
bfb bit-for-bit code health improving internal code structure to make easier to maintain (sustainability)

Comments

@billsacks
Copy link
Member

zwt, zwt_perched and frost_table are initialized in SoilHydrologyInitTimeConstMod but they aren't actually time-constant. This doesn't cause problems, but is confusing. (This may be true of other variables initialized in this module, too: I haven't looked carefully.)
@billsacks billsacks added the code health improving internal code structure to make easier to maintain (sustainability) label Nov 27, 2018
@negin513 negin513 mentioned this issue Feb 4, 2019
Merged
@negin513 negin513 self-assigned this Feb 15, 2019
@samsrabin samsrabin added simple bfb bit-for-bit labels Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@negin513 negin513

Labels
bfb bit-for-bit code health improving internal code structure to make easier to maintain (sustainability)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@billsacks @samsrabin @negin513