Bugfix for FatesSp compiled with intel

[mvdebolskiy]

Description of changes

Added assignments for mlai* variables when fates is on, but patches/columns are not fates.

Specific notes

When #2935 was merged, there were no intel tests for FatesSp that were not with 1x1_brazil so the error in #3507 has never been encountered (brazil has only 1 natveg column). Gnu somehow does not give fpe illegal operation for assignments to nan.

Contributors other than yourself, if any:

CTSM Issues Fixed (include github issue #):

#3507 maybe others

Are answers expected to change (and if so in what way)?

Should not but not ran baseline comparison yet.
ERI_D_Ld9.f45_f45_mg37.I2000Clm60FatesSpCruRsGs.derecho_intel.clm-FatesColdSatPhenCamLndTuningMode will pass now.

Any User Interface Changes (namelist or namelist defaults changes)?

No.

Does this create a need to change or add documentation? Did you do so?

No.

Testing performed, if any:

  ERI_D_Ld9.f45_f45_mg37.I2000Clm60FatesSpCruRsGs.derecho_intel.clm-FatesColdSatPhenCamLndTuningMode (Overall: PASS) details:
    PASS ERI_D_Ld9.f45_f45_mg37.I2000Clm60FatesSpCruRsGs.derecho_intel.clm-FatesColdSatPhenCamLndTuningMode CREATE_NEWCASE
    PASS ERI_D_Ld9.f45_f45_mg37.I2000Clm60FatesSpCruRsGs.derecho_intel.clm-FatesColdSatPhenCamLndTuningMode XML
    PASS ERI_D_Ld9.f45_f45_mg37.I2000Clm60FatesSpCruRsGs.derecho_intel.clm-FatesColdSatPhenCamLndTuningMode SETUP
    PASS ERI_D_Ld9.f45_f45_mg37.I2000Clm60FatesSpCruRsGs.derecho_intel.clm-FatesColdSatPhenCamLndTuningMode SHAREDLIB_BUILD time=7
    PASS ERI_D_Ld9.f45_f45_mg37.I2000Clm60FatesSpCruRsGs.derecho_intel.clm-FatesColdSatPhenCamLndTuningMode MODEL_BUILD time=34
    PASS ERI_D_Ld9.f45_f45_mg37.I2000Clm60FatesSpCruRsGs.derecho_intel.clm-FatesColdSatPhenCamLndTuningMode SUBMIT
    PASS ERI_D_Ld9.f45_f45_mg37.I2000Clm60FatesSpCruRsGs.derecho_intel.clm-FatesColdSatPhenCamLndTuningMode RUN time=225
    PASS ERI_D_Ld9.f45_f45_mg37.I2000Clm60FatesSpCruRsGs.derecho_intel.clm-FatesColdSatPhenCamLndTuningMode COMPARE_base_hybrid
    PASS ERI_D_Ld9.f45_f45_mg37.I2000Clm60FatesSpCruRsGs.derecho_intel.clm-FatesColdSatPhenCamLndTuningMode COMPARE_base_rest
    PASS ERI_D_Ld9.f45_f45_mg37.I2000Clm60FatesSpCruRsGs.derecho_intel.clm-FatesColdSatPhenCamLndTuningMode MEMLEAK insufficient data for memleak test
    PASS ERI_D_Ld9.f45_f45_mg37.I2000Clm60FatesSpCruRsGs.derecho_intel.clm-FatesColdSatPhenCamLndTuningMode SHORT_TERM_ARCHIVER
  SMS_D_Ld2.f45_f45_mg37.I2000Clm60FatesSpRsGs.derecho_intel.clm-FatesColdSatPhen (Overall: PASS) details:
    PASS SMS_D_Ld2.f45_f45_mg37.I2000Clm60FatesSpRsGs.derecho_intel.clm-FatesColdSatPhen CREATE_NEWCASE
    PASS SMS_D_Ld2.f45_f45_mg37.I2000Clm60FatesSpRsGs.derecho_intel.clm-FatesColdSatPhen XML
    PASS SMS_D_Ld2.f45_f45_mg37.I2000Clm60FatesSpRsGs.derecho_intel.clm-FatesColdSatPhen SETUP
    PASS SMS_D_Ld2.f45_f45_mg37.I2000Clm60FatesSpRsGs.derecho_intel.clm-FatesColdSatPhen SHAREDLIB_BUILD time=89
    PASS SMS_D_Ld2.f45_f45_mg37.I2000Clm60FatesSpRsGs.derecho_intel.clm-FatesColdSatPhen MODEL_BUILD time=32
    PASS SMS_D_Ld2.f45_f45_mg37.I2000Clm60FatesSpRsGs.derecho_intel.clm-FatesColdSatPhen SUBMIT
    PASS SMS_D_Ld2.f45_f45_mg37.I2000Clm60FatesSpRsGs.derecho_intel.clm-FatesColdSatPhen RUN time=72
    PASS SMS_D_Ld2.f45_f45_mg37.I2000Clm60FatesSpRsGs.derecho_intel.clm-FatesColdSatPhen MEMLEAK insufficient data for memleak test
    PASS SMS_D_Ld2.f45_f45_mg37.I2000Clm60FatesSpRsGs.derecho_intel.clm-FatesColdSatPhen SHORT_TERM_ARCHIVER

This might rather be merged in bfb-dev @ekluzek @samsrabin you can change the target if that's ok.

[mvdebolskiy]

@ekluzek
I think it might go into bfb-dev I've tested against the same tests run with ctsm5.3.084 as baselines:

mvdebolskiy@derecho6:/glade/derecho/scratch/mvdebolskiy/deftst> ./cs.status.dev_084  | grep BASELINE
    PASS SMS_D_Ld2.f45_f45_mg37.I1850Clm60Sp.derecho_intel BASELINE fdef_084:
    PASS SMS_D_Ld2.f45_f45_mg37.I2000Clm60BgcCrop.derecho_intel.clm-default BASELINE fdef_084:
    FAIL SMS_D_Ld2.f45_f45_mg37.I2000Clm60FatesSpRsGs.derecho_intel.clm-FatesColdSatPhen BASELINE fdef_084: ERROR BFAIL some baseline files were missing
    PASS SMS_D_Ld5.f45_f45_mg37.I2000Clm60Fates.derecho_intel.clm-FatesColdNoComp BASELINE fdef_084:

Can not run any gnu tests though.
SMS_D_Ld2.f45_f45_mg37.I2000Clm60FatesSpRsGs.derecho_intel.clm-FatesColdSatPhen obv fails with ctsm5.3.084.

[mvdebolskiy]

I've also removed:
ERI_D_Ld9.f45_f45_mg37.I2000Clm60FatesSpCruRsGs.derecho_gnu.clm-FatesColdSatPhenCamLndTuningMode
associated with #3496 since it was fixed in NGEET/fates#1397 which is sci.1.87.4_api.41.0.0 and we are already checking out sci.1.88.0_api.42.0.0.

[wwieder]

@ekluzek will do testing to see if this can go to b4b_dev

[ekluzek]

Discussed this morning. We should also make sure that we have a intel DEBUG test for a global grid and not just the DEBUG intel 1x1_brazil test we have now.

[rgknox]

These look fine to me. As we discussed in the SE meeting, you shouldn't need the fates patch filter. The zeroing outside the column filter should be the meaningful change. That being said, I have no problems with this.

[ekluzek]

This is great. I'm glad you caught this, and are bringing this in.