Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fsurdat file needed for NEON MOAB site #2801

Open
samsrabin opened this issue Sep 30, 2024 · 6 comments
Open

fsurdat file needed for NEON MOAB site #2801

samsrabin opened this issue Sep 30, 2024 · 6 comments
Assignees
Labels
testing additions or changes to tests

Comments

@samsrabin
Copy link
Collaborator

samsrabin commented Sep 30, 2024

I didn't want to open a whole new issue for this BUT...
In #2500 this test changed from FAIL (expected) to PEND in the SHAREDLIB_BUILD phase
SMS_Ld10_D_Mmpi-serial.CLM_USRDAT.I1PtClm60Bgc.derecho_gnu.clm-NEON-MOAB--clm-PRISM
with this error CLMBuildNamelist::add_default() : No default value found for fsurdat.

Same on izumi:
SMS_Ld10_D_Mmpi-serial.CLM_USRDAT.I1PtClm60Bgc.izumi_nag.clm-NEON-MOAB--clm-PRISM

Originally posted by @slevis-lmwg in #2310 (comment)


I'm elevating this to its own issue because now the cs.status output is confusing, and the expected failure isn't detected.

@samsrabin samsrabin added bug something is working incorrectly testing additions or changes to tests next this should get some attention in the next week or two. Normally each Thursday SE meeting. and removed bug something is working incorrectly labels Sep 30, 2024
@samsrabin
Copy link
Collaborator Author

Note that the cs.status output will make more sense—i.e., SETUP will be marked as FAIL—once we bring in cime6.1.27 or later; see ESMCI/cime#4681.

@wwieder wwieder added this to the cesm3_0_beta04 milestone Oct 3, 2024
@wwieder wwieder removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Oct 3, 2024
@slevis-lmwg
Copy link
Contributor

slevis-lmwg commented Oct 8, 2024

The file already exists here (78pft)
/glade/campaign/cesm/cesmdata/inputdata/lnd/clm2/surfdata_esmf/NEON/ctsm5.3.0/surfdata_1x1_NEON_MOAB_hist_2000_78pfts_c240912.nc
and here (16pft)
.../16PFT_mixed/surfdata_1x1_NEON_MOAB_hist_2000_16pfts_c240912.nc

@samsrabin
Copy link
Collaborator Author

So I guess something just needs to be changed in the XML for the test to pick that up?

@slevis-lmwg
Copy link
Contributor

@samsrabin this sounds simple, although @olyson and I looked at this for a few minutes this morning and found:

  1. The fsurdat setting seems correct in namelist_defaults_ctsm.xml
  2. Other neon tests work suggesting that this test does something different that causes it to break...

@slevis-lmwg
Copy link
Contributor

Additional info. This test works:
SMS_Ld10_D_Mmpi-serial.CLM_USRDAT.I1PtClm60Bgc.derecho_gnu.clm-NEON-MOAB

@samsrabin
Copy link
Collaborator Author

Ah, so it seems like the addition of the PRISM testmod is the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing additions or changes to tests
Projects
None yet
Development

No branches or pull requests

5 participants