Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make using a 16-PFT fire emissions dataset in a 78-PFT run trigger an error #2781

Open
ekluzek opened this issue Sep 24, 2024 · 0 comments
Open
Labels
usability Improve or clarify user-facing options

Comments

@ekluzek
Copy link
Collaborator

ekluzek commented Sep 24, 2024

In ctsm5.3.0 we update to using a 78 PFT fire emissions dataset. But, we also made sure that you could use the previous 16 PFT one. Going forward it might be better to trigger use of 16 PFT as an error.

As @samsrabin says here...

Well, my original concern is still there—if ( size(factors) > npfts ) will never be true here as long as if ( npfts < maxveg ) in fire_emis_factors_init() triggers an error.

  • Do we want the user to be able to run with a too-short emissions file or not? If yes, delete that error check (and rename npfts to something more descriptive, like npfts_on_emis_file). If no, delete this conditional (and the npft variable).

I say no—I don't like it when the model silently resolves what might have been a mistake on my part.

Originally posted by @samsrabin in #2500 (comment)

@ekluzek ekluzek added next this should get some attention in the next week or two. Normally each Thursday SE meeting. usability Improve or clarify user-facing options labels Sep 24, 2024
@wwieder wwieder removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Oct 3, 2024
@samsrabin samsrabin changed the title Should use of a 16 PFT fire emissions dataset trigger an error? Make using a 16-PFT fire emissions dataset in a 78-PFT run trigger an error Oct 3, 2024
@samsrabin samsrabin added this to the CESM3 Answer changing freeze milestone Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
usability Improve or clarify user-facing options
Projects
None yet
Development

No branches or pull requests

3 participants