Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error checking MPI calls in mksurfdata_esmf #2747

Open
ekluzek opened this issue Sep 9, 2024 · 1 comment
Open

Error checking MPI calls in mksurfdata_esmf #2747

ekluzek opened this issue Sep 9, 2024 · 1 comment
Labels
code health improving internal code structure to make easier to maintain (sustainability) enhancement new capability or improved behavior of existing capability test: mksurfdata Test mksurfdata_esmf before merging

Comments

@ekluzek
Copy link
Collaborator

ekluzek commented Sep 9, 2024

For issues:

#2744
#2502

in the fix we discussed adding a check for the return code from a MPI call. This would be best practice, but we also haven't consistently handled the return codes for MPI. So we should do the handling everyone in a consistent manner.

See this discussion:

slevis-lmwg#9 (comment)

@ekluzek ekluzek added enhancement new capability or improved behavior of existing capability next this should get some attention in the next week or two. Normally each Thursday SE meeting. labels Sep 9, 2024
@ekluzek
Copy link
Collaborator Author

ekluzek commented Sep 9, 2024

Note also #2352 updating the MPI calls to the FORTRAN-2008 interface which likely handles errors in a different manner.

Also perhaps the shr_mpi_mod version of MPI calls should be done rather than the lower level MPI calls directly.

@samsrabin samsrabin added code health improving internal code structure to make easier to maintain (sustainability) support tools only and removed next this should get some attention in the next week or two. Normally each Thursday SE meeting. labels Sep 12, 2024
@samsrabin samsrabin added test: mksurfdata Test mksurfdata_esmf before merging and removed support tools only labels Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code health improving internal code structure to make easier to maintain (sustainability) enhancement new capability or improved behavior of existing capability test: mksurfdata Test mksurfdata_esmf before merging
Projects
None yet
Development

No branches or pull requests

2 participants