Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hillslope_fsat_equals_zero = .true. causes a matrixcn test to fail #2652

Open
slevis-lmwg opened this issue Jul 16, 2024 · 4 comments
Open

hillslope_fsat_equals_zero = .true. causes a matrixcn test to fail #2652

slevis-lmwg opened this issue Jul 16, 2024 · 4 comments
Labels
bug something is working incorrectly priority: low Background task that doesn't need to be done right away.

Comments

@slevis-lmwg
Copy link
Contributor

slevis-lmwg commented Jul 16, 2024 •
edited by samsrabin
Loading

For now, changing

<hillslope_fsat_equals_zero                  >.true.</hillslope_fsat_equals_zero>

to

<hillslope_fsat_equals_zero use_hillslope=".true.">.true.</hillslope_fsat_equals_zero>

Originally posted by @samsrabin in #640 (comment)
@slevis-lmwg
Copy link
Contributor Author

Thread documenting the test failure and the solution starts here:
#640 (comment)

@slevis-lmwg slevis-lmwg added the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Jul 16, 2024
@slevis-lmwg
Copy link
Contributor Author

Bottom line:
We do not want hillslope_fsat_equals_zero = .true. to change answers when use_hillslope = .false.

@slevis-lmwg slevis-lmwg added bug something is working incorrectly and removed next this should get some attention in the next week or two. Normally each Thursday SE meeting. labels Jul 18, 2024
@samsrabin samsrabin added the priority: low Background task that doesn't need to be done right away. label Jul 18, 2024
@samsrabin
Copy link
Collaborator

@slevis-lmwg This was resolved with #640, no?

@slevis-lmwg
Copy link
Contributor Author

We addressed it by masking the problem with this fix:
#640 (comment)

So we kept this issue open to remember that something strange was happening that we masked with the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug something is working incorrectly priority: low Background task that doesn't need to be done right away.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samsrabin @slevis-lmwg