Should we now allow constants in the FORTRAN code be all uppercase? And start making that change in the code?

[ekluzek]

As discussed here:

#2401 (comment)

There's a desire to use all uppercase for constants in the FORTRAN code. I do find this nicely readable. But, as discussed above we didn't allow it because ALL uppercase was reserved for CPP tokens. However, we almost don't have any CPP tokens in the code anymore. And haven't for at least a decade now? So maybe we could start allowing it?

And as a future cleanup after CESM3 do we move to making this change for all constants?

[samsrabin]

Decision: Yes, let's.

• Use UPPERCASE for constants moving forward. (Let's not comprehensively search and replace yet.)
• @adrifoster will go ahead and update the standards wiki to reflect this.

[samsrabin]

@adrifoster also thought about putting constants in a class, like math.pi in Python. But you can't actually set parameters in a FORTRAN class, unless you want to access them through a function.