Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of set_* arguments in hist_addfld calls #1350

Open
billsacks opened this issue Apr 19, 2021 · 0 comments
Open

Get rid of set_* arguments in hist_addfld calls #1350

billsacks opened this issue Apr 19, 2021 · 0 comments
Labels
code health improving internal code structure to make easier to maintain (sustainability)

Comments

@billsacks
Copy link
Member

Although this is still open to discussion (I'll open a discussion issue shortly), I propose getting rid of the set_* arguments in hist_addfld calls. In cases where we have set_=spval, we're going to use landunit_mask (#1347). In places where we have set_=0, my preference is to do this setting in initCold instead: I find it unintuitive to set fields to certain values in the hist_addfld call, and I'm also concerned that doing the setting in the hist_addfld call can be misleading because this could be overridden later in the code (i.e., it is not guaranteed that the field will remain at the value set via the set_* argument).

@billsacks billsacks added the code health improving internal code structure to make easier to maintain (sustainability) label Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code health improving internal code structure to make easier to maintain (sustainability)
Projects
None yet
Development

No branches or pull requests

1 participant