Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After removing initial settings of history fields to spval, search code for remaining uses of spval #1348

Open
billsacks opened this issue Apr 19, 2021 · 2 comments
Labels
blocker another issue/PR depends on this one code health improving internal code structure to make easier to maintain (sustainability)

Comments

@billsacks
Copy link
Member

After doing #1347 we should search for remaining uses of spval in the code, making sure the only ones left really should be there. In particular, we should make sure we don't have any more uses of spval to represent uncalculated values in certain landunits. This is important to make sure the landunit_mask metadata is correct, and for some further cleanup that we can do if spvals are no longer used in this way.

@billsacks billsacks added the code health improving internal code structure to make easier to maintain (sustainability) label Apr 19, 2021
@billsacks
Copy link
Member Author

I see initialization of the output array to spval in p2c_1d (and maybe other subgridAveMod routines). I think this could actually abort if a given output array value would end up unassigned. Or, if that doesn't work, then could initialize to NaN rather than spval.

@billsacks
Copy link
Member Author

Blocks #1349

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker another issue/PR depends on this one code health improving internal code structure to make easier to maintain (sustainability)
Projects
None yet
Development

No branches or pull requests

1 participant