Skip to content
This repository was archived by the owner on Aug 2, 2022. It is now read-only.

net_plugin reduce signed_block copies#6397

Merged
heifner merged 10 commits into
developfrom
blk-copy
Nov 28, 2018
Merged

net_plugin reduce signed_block copies#6397
heifner merged 10 commits into
developfrom
blk-copy

Conversation

@heifner
Copy link
Copy Markdown
Contributor

@heifner heifner commented Nov 27, 2018

Change Description

  • Made signed_block copy constructor private so the compiler will prevent accidental copies of signed_block
  • Updated net_plugin to avoid unneeded signed_block copies

Consensus Changes

None

API Changes

net_plugin message format did NOT change.

Documentation Additions

None

@heifner heifner changed the title [WIP do not merge] net_plugin reduce signed_block copies net_plugin reduce signed_block copies Nov 27, 2018
Comment thread plugins/net_plugin/net_plugin.cpp Outdated
Comment thread plugins/chain_plugin/include/eosio/chain_plugin/chain_plugin.hpp Outdated
Comment thread plugins/chain_plugin/chain_plugin.cpp Outdated
Comment thread plugins/net_plugin/net_plugin.cpp Outdated
Comment thread plugins/net_plugin/net_plugin.cpp Outdated
@heifner heifner merged commit 760f2b4 into develop Nov 28, 2018
@heifner heifner deleted the blk-copy branch November 28, 2018 02:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants