This repository was archived by the owner on Aug 2, 2022. It is now read-only.
Fix for transaction_traces store in mongo_db_plugin#6130
Merged
Conversation
…e disabled. Filtering still applies.
brianjohnson5972
approved these changes
Oct 24, 2018
| bool added = false; | ||
| if( start_block_reached && store_action_traces && | ||
| filter_include( atrace.receipt.receiver, atrace.act.name, atrace.act.authorization ) ) { | ||
| bool in_filter = (store_action_traces || store_transaction_traces) && start_block_reached && |
Contributor
There was a problem hiding this comment.
Would prefer const bool in_filter since nothing else is changing
| const chain::transaction_trace_ptr& t, | ||
| bool executed, const std::chrono::milliseconds& now ) | ||
| bool executed, const std::chrono::milliseconds& now, | ||
| bool& write_ttrace ) |
Contributor
There was a problem hiding this comment.
Not sure what to do with it, but would like to point out that returning write_atrace (essentially) and setting a reference for write_ttrace doesn't make for a clear interface.
brianjohnson5972
approved these changes
Oct 24, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Resolves #6088