ci: finalize github release action

[DaniBodor]

• fix branch names to main and develop instead of test_protected_XXX
  • forgot to do this in ci: github release action #242
• use built-in branch reading system for GitHub actions (see here)
  • this is mostly more convenient than the explicit one I wrote
    • because the built-in one cannot be hidden, so would otherwise appear but have no function
    • because the built-in one uses a drop-down menu (with search functionality) of existing branches rather than a string input for the one I wrote
  • the downside is: the default cannot be changed to anything other than main, which should never actually be the release branch (the workflow will fail if main is set).

NB: I am also a bit confused now whether this PR should go to main or develop. I think main, so that the action can immediately be used as intended.

[psomhorst]

Seems great!

You merged the previous PR #242 into main, so this should as well. This file has to exist in main before it becomes available anyway.
However, you can only use it from a branch where it already exists (see attached screenshot). So we should merge main into develop after this PR. Then, we can use it from develop.

Isn't it possible to limit the working of workflow_dispath by adding a branch setting, just as with on: push:?

Edit: never mind, this of course won't work with branches you don't know the name of yet (e.g. hot fix branches).

Documentatie over hoe je master kan uitsluiten?

eitprocessing/.github/workflows/release_github.yml

Lines 3 to 4 in dc07d37

	on:
	workflow_dispatch:

eitprocessing/.github/workflows/build.yml

Lines 3 to 6 in 7b1c204

	on:
	push:
	branches:
	- main

[psomhorst]

Should the action default to develop if you select main? This could lead to unexpected behaviour and unintentional releases.

Edit: sorry, I'm a bit indecisive, apparently.

[DaniBodor]

It's easy enough to make the action fail if main is selected, that is no problem.
The annoying thing is that it's not possible to set the default for "Use workflow from" to anything other than main. So the question is: do we prefer

1. a smoother user experience (i.e. re-default it to develop): e039e69
2. decrease the probability of unexpected behavior (i.e. fail if main is selected): c72cf34

Also, don't forget that there is already a manual quality control step built in, by creating a draft-release, which actively needs to be converted to an actual release.

EDIT: we decided to go with option 2!