stream_position property support is missing ?

[cyberpsyche]

Hi @EIREXE , thanks for your work on this GDExtension. Ultimately I could run it on my machine. :)

But I found that the VideoStreamPlayer node cannot set 'stream_position' property in gdscript. The code just overlook this setting and always play the stream from the very beginning. As stream_position is a very very important property of the stream playback, will you please add this feature in your code?

Thanks!

[EIREXE]

How are you setting the stream_position? I myself have found that setting it using set_stream_position fails, but just setting the stream_position property works fine

[cyberpsyche]

I set the stream_position property by this kind of code snippet:

	var ffmpeg_stream = FFmpegVideoStream.new()
	ffmpeg_stream.file = "/Users/chris/media/seeyou.mp4"	
	$VideoStreamPlayer.stream = ffmpeg_stream
	$VideoStreamPlayer.stream_position = 2.0
	$VideoStreamPlayer.play()

Any suggestion?

[EIREXE]

I set the stream_position property by this kind of code snippet:

	var ffmpeg_stream = FFmpegVideoStream.new()
	ffmpeg_stream.file = "/Users/chris/media/seeyou.mp4"	
	$VideoStreamPlayer.stream = ffmpeg_stream
	$VideoStreamPlayer.stream_position = 2.0
	$VideoStreamPlayer.play()

Any suggestion?

try calling play() before seeking, that should work

[zedrun00]

Hi, How get video length in gds ? my need set stream_position in HSlider Node by percentage
@EIREXE

[EIREXE]

Hi, How get video length in gds ? my need set stream_position in HSlider Node by percentage @EIREXE

I think the ability to get the length was removed in 4.0 or was never there in the first place, not sure why.

[zedrun00]

This is regrettable, So is there any other way, can make a video progress bar? @EIREXE

[EIREXE]

This is regrettable, So is there any other way, can make a video progress bar? @EIREXE

For the time being I think you'll have to figure out the time externally and bake it in, or modify the engine to add an API to get the length

[zedrun00]

This is regrettable, So is there any other way, can make a video progress bar? @EIREXE

For the time being I think you'll have to figure out the time externally and bake it in, or modify the engine to add an API to get the length

I can't, I don't have the ability to modify the engine right now. If you make it. call me， thank you！ :)

[rsubtil]

AFAICT there was never a way to get the video stream length, despite Godot 3.x having a get_length field.

The godot-videodecoder uses a hack where you seek to a negative value to find the video length:
https://github.com/kidrigger/godot-videodecoder/blob/af71383dce66eea88f3ce99b416613b925be3ba0/src/gdnative_videodecoder.c#L1086-L1089

I do think that this issue has been here for too long for something that is simple, so I'll look into getting this finally implemented in Godot.

[rsubtil]

Oh, nevermind, this got merged recently (godotengine/godot#77858), so this should now be possible to implement.

[trekfan42]

AFAICT there was never a way to get the video stream length, despite Godot 3.x having a get_length field.

The godot-videodecoder uses a hack where you seek to a negative value to find the video length: https://github.com/kidrigger/godot-videodecoder/blob/af71383dce66eea88f3ce99b416613b925be3ba0/src/gdnative_videodecoder.c#L1086-L1089

I do think that this issue has been here for too long for something that is simple, so I'll look into getting this finally implemented in Godot.

this is my solution:
I bundle ffprobe with the package then send it a command to get the length

func ffprobe(path):
	print( "checking duration of video at: " + path)
	var ffprobe = ProjectSettings.globalize_path("res://ffprobe.exe")
	var args = ["-v", "error", "-select_streams", "v:0", "-show_entries", "format=duration", "-of", "default=noprint_wrappers=1", path ]
	# ffprobe.exe -v error -select_streams v:0 -show_entries format=duration -of default=noprint_wrappers=1 test.mp4
	var output = []
	
	var result = OS.execute(ffprobe,args,output,true,false)
	
	var dur0 = output[0]
	var dur1 = dur0.replace("duration=","")
	var dur2 = dur1.replace("\r\n","")
	var videoLength = round(float(dur2))
	print("execute result: " + str(videoLength))
	
	return videoLength

[trekfan42]

So seeking is working mostly, but it's inconsistent and i get this error often when seeking with a HSlider:

Video too far out of sync (1900.00), seeking to 25050.22
Video too far out of sync (28940.67), seeking to 53050.65
Video too far out of sync (53074.67), seeking to 56216.58
Video too far out of sync (53141.33), seeking to 56250.49

https://streamable.com/4usyih

It seems like if i try to seek too far, i get the error and it never recovers, but then i can go back to the beginning and recover

[EIREXE]

So seeking is working mostly, but it's inconsistent and i get this error often when seeking with a HSlider:

Video too far out of sync (1900.00), seeking to 25050.22 Video too far out of sync (28940.67), seeking to 53050.65 Video too far out of sync (53074.67), seeking to 56216.58 Video too far out of sync (53141.33), seeking to 56250.49

https://streamable.com/4usyih

It seems like if i try to seek too far, i get the error and it never recovers, but then i can go back to the beginning and recover

Are you constantly seeking or only seeking when letting go?

[EIREXE]

Oh, nevermind, this got merged recently (godotengine/godot#77858), so this should now be possible to implement.

Currently on vacation but I'll implement it as soon as I return

[trekfan42]

So seeking is working mostly, but it's inconsistent and i get this error often when seeking with a HSlider:
Video too far out of sync (1900.00), seeking to 25050.22 Video too far out of sync (28940.67), seeking to 53050.65 Video too far out of sync (53074.67), seeking to 56216.58 Video too far out of sync (53141.33), seeking to 56250.49
https://streamable.com/4usyih
It seems like if i try to seek too far, i get the error and it never recovers, but then i can go back to the beginning and recover

Are you constantly seeking or only seeking when letting go?

On slider drag start I pause. Then on drag finish I seek to the slider value.

func _on_play_slider_drag_ended(value_changed):
	videoBox.set_stream_position(playslider.value)
	seeking = false
        videoBox.paused = false

func _on_play_slider_drag_started():
	videoBox.paused = true
	seeking = true

Also not sure if its related but it's also usually correlated to the audio playing first then the video, so there is a desync, then i have to pause and wait for it to catch up then I can play again in sync.
sometimes the video comes back but with no audio and i have to reload the path and position to get audio back

but sometimes if I drag too far away from the current position, I never get audio or video, just that out of sync error message