Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop recording no-tracking-detected third-party domains #1446

Closed
ghostwords opened this issue Jun 20, 2017 · 3 comments
Closed

Stop recording no-tracking-detected third-party domains #1446

ghostwords opened this issue Jun 20, 2017 · 3 comments
Labels
DNT policy EFF's Do Not Track policy: www.eff.org/dnt-policy heuristic Badger's core learning-what-to-block functionality important migrations Badger user data modifications performance privacy General privacy issues; stuff that isn't about Privacy Badger's heuristic

Comments

@ghostwords
Copy link
Member

ghostwords commented Jun 20, 2017

We currently record non-tracking third-parties in action_map (with heuristicAction of ""). We should keep showing these third-party resources in the popup for now, but if that's the only place we actually use these entries, they don't need to be persisted. (The code might not use action_map directly in the popup, so removal might be easy.) Should do a migration to clean up existing entries.

Should help a little with performance, mitigate #1318, address part of #1064. Obsoletes #1339? Related earlier issue: #990. Might also take care of #888, at least for both known cases.

@ghostwords ghostwords added heuristic Badger's core learning-what-to-block functionality performance privacy General privacy issues; stuff that isn't about Privacy Badger's heuristic labels Jun 20, 2017
@ghostwords
Copy link
Member Author

We should handle the case of a user deciding to block or cookieblock one of these domains in the popup. May already be fine, just noting.

@ghostwords
Copy link
Member Author

ghostwords commented Jun 20, 2017

Should non-tracking, DNT domains be persisted?

@cowlicks
Copy link
Contributor

@ghostwords Yes I think non-tracking DNT domains should be persisted.

Work on this is ongoing here master...cowlicks:stop-tracking-no-tracking-domains-lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DNT policy EFF's Do Not Track policy: www.eff.org/dnt-policy heuristic Badger's core learning-what-to-block functionality important migrations Badger user data modifications performance privacy General privacy issues; stuff that isn't about Privacy Badger's heuristic
Projects
None yet
Development

No branches or pull requests

2 participants