Fix for for python >= 3.11 #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until python 3.11 IntEnum.srt() returned "<Enum name>.<member name>"
But since then it returns the string of its numeric value instead.
This causes errors like:
File "edtt/src/components/attdata.py", line 374, in __str__
result = self.__opcodeName( opcode );
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "edtt/src/components/attdata.py", line 349, in __opcodeName
result = result.split('.')[1];
~~~~~~~~~~~~~~~~~^^^
Let's pick the "name" instead which is directly the Enum member name.
This works both with newer and older python versions since enum was
added in version 3.4.
Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
aescolar
requested review from
Tronil,
daor-oti,
mtpr-ot,
niag-Oticon,
thoh-ot and
wopu-ot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until python 3.11 IntEnum.srt() returned
<Enum name>.<member name>But since then it returns the string of its numeric value instead. This causes errors like:Let's pick the "name" instead which is directly the Enum member name. This works both with newer and older python versions since enum was added in version 3.4.
https://docs.python.org/3/library/enum.html#enum.IntEnum