-
Notifications
You must be signed in to change notification settings - Fork 28
Update CAPI Endpoints for Vanguards update #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| 1. `factionName` - Name of aligned faction | ||
| 1. `factionHomeSystemId` - Numerical system Id of faction's home system | ||
| 1. `factionHomeSystemName` - Name of faction's home system | ||
| 1. `userTags` - UNCLEAR (NEED INPUT) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how to decipher the userTags either. Maybe the numbers correspond to selections when creating the squadron badge?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What, like "Exploration" or "Combat"? Possibly! We will probably need to do some digging to get a translation between the numbers and their "display names"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have assumed that they are the 'combat' / 'trade' / ect tags, and we can update them later if not
| 1. `rank_id` - Numerical Rank ID | ||
| 1. `requestletter` - Hex encoded message sent with join request | ||
| 1. `credit_contributions` - Credits deposited in squad bank | ||
| 1. `presence` - UNCLEAR (NEED INPUT) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have presence as false for all squadron members.
Hypothesis: Perhaps it becomes true when a squadron member is sharing the same instance as you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly, although given this is a cApi endpoint I assume it would not be real time? Only one way to find out I suppose
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely shouldn't count on it being real-time. I'm just making a guess here. :-D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few minor comments but overall this looks great. Thank you!
|
@Tkael updated to reflect your input (thanks!) |
Fields that need clarification:
userTags- array of integerssquadronCarrier.capacity.microresourceCapacityReserved- IntegersquadronCarrier.finance.numOptionalServices- Integermembers.expires_ts- Unix timestampmembers.presence- Boolean