Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub: Replace current 'Create Draft Release' code with GitHub CLI #1704

Closed
Athanasius opened this issue Nov 18, 2022 · 2 comments
Closed
Labels
enhancement github_actions Pull requests that update Github_actions code

Comments

@Athanasius
Copy link
Contributor

Our windows-build.yaml is configured to utilise https://github.com/softprops/action-gh-release to create a draft release after the build completes.

Unfortunately that action hasn't, yet, been updated to change from set-output to Environment Files:

 Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

There's an open issue, but no response from the developer.

There is a comment about just using the GitHub CLI instead: softprops/action-gh-release#265 (comment)

So, investigate that, or other alternatives. Keep in mind we want a DRAFT release from this action.

@Athanasius Athanasius added enhancement github_actions Pull requests that update Github_actions code labels Nov 18, 2022
@A-UNDERSCORE-D
Copy link
Contributor

gh release create $tag --draft --discussion-category Release/$tag


https://cli.github.com/manual/gh_release_create

@Athanasius
Copy link
Contributor Author

It appears that softprops has updated now, possibly just by updating its own dependencies.

Either way I didn't get the warnings when building 5.6.1 just now -> https://github.com/EDCD/EDMarketConnector/actions/runs/3601587722/jobs/6067613851

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement github_actions Pull requests that update Github_actions code
Projects
None yet
Development

No branches or pull requests

2 participants