Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve <diags>.<species>.variables = none #4917

Open
ax3l opened this issue May 8, 2024 · 4 comments
Open

Improve <diags>.<species>.variables = none #4917

ax3l opened this issue May 8, 2024 · 4 comments
Assignees
Labels
bug: affects latest release Bug also exists in latest release version bug Something isn't working component: diagnostics all types of outputs component: openPMD openPMD I/O geometry: RZ axisymmetric 2D and quasi-3D

Comments

@ax3l
Copy link
Member

ax3l commented May 8, 2024

Tested with Examples/Physics_applications/laser_acceleration/inputs_3d.

Even with

diag1.electrons.variables = none

we still write runtime integer attribute regionofinterest unconditionally

electrons.addIntegerAttributes = regionofinterest
electrons.addRealAttributes = initialenergy

(but interestingly not the real attribute initialenergy)

And the id of a particle is also written unconditionally.

This should be improved.

Follow-up to #4914

@ax3l ax3l added bug Something isn't working component: openPMD openPMD I/O bug: affects latest release Bug also exists in latest release version component: diagnostics all types of outputs labels May 8, 2024
@ax3l ax3l self-assigned this May 8, 2024
@ax3l
Copy link
Member Author

ax3l commented May 8, 2024

Also, seen with Examples/Physics_applications/laser_acceleration/inputs_rz, filtering of positions in RZ does not really work.

The whole m_plot_flags logic should be factored out of ParticleDiag.cpp and either put directly into the backends or generalized with the r,z,theta -> x,y,z logic that is supported in (some?) of the backends.

This whole upfront parsing and bookkeeping in unrelated arrays like m_plot_flags is too fragile and error-prone, not dealing properly with runtime-added attributes, etc.

@ax3l ax3l added geometry: RZ axisymmetric 2D and quasi-3D geometry: 1D/2D Lower-dimensional Cartesian specific and removed geometry: 1D/2D Lower-dimensional Cartesian specific labels May 8, 2024
@ax3l
Copy link
Member Author

ax3l commented May 8, 2024

Another test to to run: dumping the phi runtime attribute in ES examples (exists only in the pinned, filtered PC).

@RemiLehe
Copy link
Member

RemiLehe commented May 8, 2024

Here is the PR that added the phi output: #4599

@ax3l
Copy link
Member Author

ax3l commented May 8, 2024

Discussed: The implicit solver also adds runtime attributes that might become out of sync with the dump flags (even if we do not mean to dump the auxiliary positions&momenta we add).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: affects latest release Bug also exists in latest release version bug Something isn't working component: diagnostics all types of outputs component: openPMD openPMD I/O geometry: RZ axisymmetric 2D and quasi-3D
Projects
None yet
Development

No branches or pull requests

2 participants