Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calls to FillBoundaryAux() #1534

Open
EZoni opened this issue Nov 25, 2020 · 0 comments
Open

Calls to FillBoundaryAux() #1534

EZoni opened this issue Nov 25, 2020 · 0 comments
Labels
component: parallelization Guard cell exchanges and particle redistribution

Comments

@EZoni
Copy link
Member

EZoni commented Nov 25, 2020

Following up on #1522, this is to remind us that the following call

#ifndef WARPX_USE_PSATD
// TODO Remove call to FillBoundaryAux before UpdateAuxilaryData?
FillBoundaryAux(guard_cells.ng_UpdateAux);
#endif

seems necessary in order for the NCI corrector (with the FDTD solver) to work correctly with mesh refinement.

In other words, if that call is removed, the CI test nci_correctorMR fails (no NCI mitigation).

However, if the call is removed AND warpx.safe_guard_cells = 1, then the CI test passes.

This suggests that we might be doing something wrong somewhere with the guard cells. Once fixed, it might be eventually possible to remove the call above, leaving only the one added after UpdateAuxilaryData():

UpdateAuxilaryData();
FillBoundaryAux(guard_cells.ng_UpdateAux);

@EZoni EZoni added the component: parallelization Guard cell exchanges and particle redistribution label Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: parallelization Guard cell exchanges and particle redistribution
Projects
None yet
Development

No branches or pull requests

1 participant