You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
// TODO Remove call to FillBoundaryAux before UpdateAuxilaryData?
FillBoundaryAux(guard_cells.ng_UpdateAux);
#endif
seems necessary in order for the NCI corrector (with the FDTD solver) to work correctly with mesh refinement.
In other words, if that call is removed, the CI test nci_correctorMR fails (no NCI mitigation).
However, if the call is removed AND warpx.safe_guard_cells = 1, then the CI test passes.
This suggests that we might be doing something wrong somewhere with the guard cells. Once fixed, it might be eventually possible to remove the call above, leaving only the one added after UpdateAuxilaryData():
Following up on #1522, this is to remind us that the following call
WarpX/Source/Evolve/WarpXEvolve.cpp
Lines 117 to 120 in bedec34
seems necessary in order for the NCI corrector (with the FDTD solver) to work correctly with mesh refinement.
In other words, if that call is removed, the CI test
nci_correctorMR
fails (no NCI mitigation).However, if the call is removed AND
warpx.safe_guard_cells = 1
, then the CI test passes.This suggests that we might be doing something wrong somewhere with the guard cells. Once fixed, it might be eventually possible to remove the call above, leaving only the one added after
UpdateAuxilaryData()
:WarpX/Source/Evolve/WarpXEvolve.cpp
Lines 121 to 122 in bedec34
The text was updated successfully, but these errors were encountered: