Open
Conversation
e
commented
Dec 19, 2018
Member
Author
There was a problem hiding this comment.
It's good, we only need to fix one calculation and finish the last one. Also, remember to remove all breakpoints. I think it's OK to have a comment with the name of the variable before each calculation, it's not needed but improves readability. However I would leave just one blank line before an none after, like this:
new_input_df = pd.concat([new_input_df, result_1, result_3], sort=True)
# UBCA.1.0.0.0
addends = {'UBCA.1.0.0.0': ['UXGS.1.0.0.0', '-UMGS.1.0.0.0', 'UBYA.1.0.0.0']}But it's just a matter of taste really
| class ExternalSector(SumAndSpliceMixin): | ||
| def perform_computation(self, result_1, result_3, ameco_h_df): | ||
| # TODO: Check the scales of the output variables | ||
| splicer = Splicer() |
Member
Author
There was a problem hiding this comment.
These two lines are not required?
| # STEP 15 | ||
| class PrivateSector(SumAndSpliceMixin): | ||
| def perform_computation(self, result_1, result_12, result_13, result_14, ameco_h_df): | ||
| breakpoint() |
Member
Author
There was a problem hiding this comment.
Remember to delete all breakpoints
| step_16 = ExternalSector(scales=self.scales) | ||
| result_16 = step_16.perform_computation(self.result_1, result_3, self.ameco_df) | ||
|
|
||
| breakpoint() |
| res_wrong, exp_wrong = res.loc[wrong_names].copy(), exp.loc[wrong_names].copy() | ||
| report_diff(res_wrong, exp_wrong) | ||
|
|
||
| #breakpoint() No newline at end of file |
| self.result = self.result.append(series, ignore_index=True, sort=True) | ||
|
|
||
| # DBGE.1.0.0.0 | ||
|
|
Member
Author
There was a problem hiding this comment.
Fix this calculation, it doesn't match the original one
| series = series.append(dbge_data) | ||
| self.result = self.result.append(series, ignore_index=True, sort=True) | ||
|
|
||
| # TODO: DBGI.1.0.0.0 |
Member
Author
There was a problem hiding this comment.
Finish the module, perform the last calculation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.