Fixes for partial time overlap causing a 2 day long birthday.

Author: mikeckennedy

apps/03_birthday/final/program.py

@@ -2,44 +2,43 @@
 
 
 def print_header():
-    print('-----------------------------------')
-    print('        BIRTHDAY APP')
-    print('-----------------------------------')
+    print('---------------------------')
+    print('      BIRTHDAY APP')
+    print('---------------------------')
     print()
 
 
 def get_birthday_from_user():
-    print('Tell us when you were born: ')
-    year = int(input('Year [YYYY]: '))
-    month = int(input('Month [MM]: '))
-    day = int(input('Day [DD]: '))
+    print("When were you born? ")
+    year = int(input("Year [YYYY]: "))
+    month = int(input("Month [MM]: "))
+    day = int(input("Day [DD]: "))
 
-    birthday = datetime.datetime(year, month, day)
+    birthday = datetime.date(year, month, day)
     return birthday
 
 
-def compute_days_between_dates(original_date, now):
-    date1 = now
-    date2 = datetime.datetime(now.year, original_date.month, original_date.day)
-    dt = date1 - date2
-    days = int(dt.total_seconds() / 60 / 60 / 24)
-    return days
+def compute_days_between_dates(original_date, target_date):
+    this_year = datetime.date(target_date.year, original_date.month, original_date.day)
+
+    dt = this_year - target_date
+    return dt.days
 
 
 def print_birthday_information(days):
     if days < 0:
-        print('Your birthday is in {} days!'.format(-days))
+        print("You had your birthday {} days ago this year.".format(-days))
     elif days > 0:
-        print('You had your birthday already this year! {} days ago'.format(days))
+        print("Your birthday is in {} days!".format(days))
     else:
-        print('Happy birthday!!!')
+        print("Happy birthday!!!")
 
 
 def main():
     print_header()
     bday = get_birthday_from_user()
-    now = datetime.datetime.now()
-    number_of_days = compute_days_between_dates(bday, now)
+    today = datetime.date.today()
+    number_of_days = compute_days_between_dates(bday, today)
     print_birthday_information(number_of_days)
 
 

apps/03_birthday/you_try/README.md

@@ -28,11 +28,11 @@ Key concepts introduced
 
 All of these come from the module `datetime`.
 
-* `datetime.datetime # actual date with time class`
+* `datetime.date # actual date class`
 * `datetime.timedelta # class for time spans`
-* The time right now is `datetime.datetime.now()`
-* The difference between two times is done via subtraction: `delta = t1 - t0`
-* `delta.total_seconds()` may be helpful ;)
+* The time right now is `datetime.date.today()`
+* The difference between two dates is done via subtraction: `delta = t1 - t0`
+* `delta.days` may be helpful ;)