Ветка 17-го спринта #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ированы настройки цветов.
…о удаление привычки.
…ление и открепление привычки.
…ыбранный день, кнопка фильтрации будет скрыта. При переключении в календаре дней действие фильра не отменяется. Настроен визуальный сигнал отображающий то, что фильтр активен.
…ота EditingHabitsViewController
So1ovyov
reviewed
Apr 12, 2024
| @@ -0,0 +1,115 @@ | |||
| /* | |||
So1ovyov
reviewed
Apr 12, 2024
| innerRect.addSubview(statsLabel) | ||
| innerRect.addSubview(statsNameLabel) | ||
|
|
||
| innerRect.translatesAutoresizingMaskIntoConstraints = false |
There was a problem hiding this comment.
Обрати внимание на инструмент forEach при верстке и настройке элементов, он поможет тебе сократить повторяющийся код
Вот пример:
[view1,
view2,
view3].forEach {
$0.translatesAutoresizingMaskIntoConstraints = false
view.addSubview($0)
}
Таким образом все строки translatesAutoresizingMaskIntoConstraints и addSubview выше можно удалить и очень сильно сократить код
So1ovyov
reviewed
Apr 12, 2024
| ]) | ||
| } | ||
|
|
||
| private func showPlaceholder() { |
There was a problem hiding this comment.
Этот метод и следующий очень схожи, может объединим ?
private func changeStatePlaceholder(isHidden: Bool) {
emptyStateImageView.isHidden = !isHidden
emptyStateLabel.isHidden = !isHidden
bestPeriodLabel.isHidden = isHidden
perfectDaysLabel.isHidden = isHidden
completedTrackersLabel.isHidden = isHidden
averageLabel.isHidden = isHidden
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.