Skip to content

add alc support #3234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
pinzart90 wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

add alc support #3234

pinzart90 wants to merge 2 commits into from

Conversation

@pinzart90
Copy link
Collaborator

@pinzart90 pinzart90 commented Oct 13, 2025 •
edited
Loading

Add this addin to enable revit isolation

<?xml version="1.0" encoding="utf-8" standalone="no"?>
<RevitAddIns>
  <AddIn Type="Application">
    <Name>Dynamo For Revit</Name>
    <Assembly>D:\dev\DynamoRevit\bin\NET80\Debug\Revit\DynamoRevitDS.dll</Assembly>
    <AddInId>8D83C886-B739-4ACD-A9DB-1BC78F315B9B</AddInId>
    <FullClassName>Dynamo.Applications.DynamoRevitApp</FullClassName>
    <VendorId>ADSK</VendorId>
    <VendorDescription>Dynamo</VendorDescription>
  </AddIn>
  <ManifestSettings>
    <UseRevitContext>False</UseRevitContext>
    <ContextName>Tiberica</ContextName>
  </ManifestSettings>
</RevitAddIns>

amatviichuk
amatviichuk reviewed Nov 14, 2025
View reviewed changes
Copy link
Collaborator

@amatviichuk amatviichuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more Assembly.loadFromcall need to be replaced.

Just a reminder: Make sure that Dynamo.addin file sets Dynamo for <ContextName>value, otherwise it will be loaded into a separate context.

src/DynamoRevit/DynamoRevitApp.cs
try
{
var dynamoRevitAditionsAss = Assembly.LoadFrom(dynamoRevitAditionsPath);
var dynamoRevitAditionsAss = AssemblyLoadContext.GetLoadContext(Assembly.GetExecutingAssembly()).LoadFromAssemblyPath(dynamoRevitAditionsPath);
Copy link
Collaborator

@amatviichuk amatviichuk Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one more Assembly.LoadFrom call in this file that also needs to be replaced. See Line number #62.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@amatviichuk amatviichuk amatviichuk left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Do Not Merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pinzart90 @amatviichuk @Mikhinja