DYN-9829: Fix hidden resize grip in ScriptEditorWindow #16756
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9829
There was a problem hiding this comment.
Pull request overview
This PR adds a custom resize grip to the ScriptEditorWindow to improve visual alignment. The default resize grip was being overlapped by the window border, so this change implements a custom grip positioned inside the visible window area using Win32 API calls.
Key Changes:
- Changed the window's
ResizeModefromCanResizeWithGriptoCanResizeto disable the default grip - Added a custom
ResizeGripcontrol with manual positioning and event handling - Implemented Win32 interop to trigger window resizing when the custom grip is dragged
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| ScriptEditorWindow.xaml.cs | Added Win32 interop constants, P/Invoke declaration, and mouse event handler to implement custom resize functionality |
| ScriptEditorWindow.xaml | Replaced default resize mode with custom ResizeGrip control positioned inside window border |
| private const int WM_SYSCOMMAND = 0x0112; | ||
| private const int SC_SIZE = 0xF000; | ||
| private const int HTBOTTOMRIGHT = 0x0008; |
There was a problem hiding this comment.
The constant names follow Win32 convention but are not sufficiently descriptive for C# code. Consider renaming to WindowsMessageSystemCommand, SystemCommandSize, and HitTestBottomRight respectively, or add XML documentation comments explaining what these magic values represent.
There was a problem hiding this comment.
These are standard Win32 names. I've added comment above to clarify their use
| private void WindowResizeGrip_OnPreviewMouseLeftButtonDown(object sender, MouseButtonEventArgs e) | ||
| { | ||
| if (WindowState != WindowState.Normal) | ||
| return; | ||
|
|
||
| var helper = new WindowInteropHelper(this); | ||
| SendMessage(helper.Handle, WM_SYSCOMMAND, (IntPtr)(SC_SIZE + HTBOTTOMRIGHT), IntPtr.Zero); | ||
| e.Handled = true; | ||
| } |
There was a problem hiding this comment.
The event handler lacks XML documentation. Add a summary comment explaining that this method triggers Win32-based window resizing when the custom resize grip is clicked, and why the custom implementation is necessary (to keep the grip inside the window border).
There was a problem hiding this comment.
OTT but now addressed.
ivaylo-matov
changed the title
Update ScriptEditorWindow.xaml.cs
…m/ivaylo-matov/Dynamo into Python-script-editor-resize-thumb
1 participant
Purpose
Small PR following that can be logged under DYN-9829.
Added a custom resize grip in
ScriptEditorWindowso the resize handle stays inside the visible window border. Previously, the window border overlapped the default resize grip.Declarations
Check these if you believe they are true
Release Notes
Added a custom resize grip in
ScriptEditorWindowso the resize handle stays inside the visible window border. Previously, the window border overlapped the default resize grip.Reviewers
@zeusongit
@DynamoDS/eidos
FYIs
@dnenov
@achintyabhat