-
Notifications
You must be signed in to change notification settings - Fork 665
DYN-8303: Enable deferred node load #16361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zeusongit
wants to merge
46
commits into
DynamoDS:master
Choose a base branch
from
zeusongit:DYN-8303-new
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
25dae72
FirstPass
saintentropy 5a87ccd
Progress update
saintentropy 106b8ed
Add Inport triggers and tooltip
saintentropy fa31803
Progress Update
saintentropy 6724c68
Progress on NodeView
saintentropy 13b986d
Simplify InPorts including lazy load of level spinner
saintentropy 7ce45f0
Cleanup + Support Code blocks
saintentropy e940553
Simplify Ports and verify with Groups
saintentropy 1d71b38
Add NodeAutoCompleteHover to InPort
saintentropy 6c6cdd8
Finish node ui
saintentropy f87bcf2
fix typo
saintentropy 24a854d
Merge branch 'master' into CodeOnlyNodeView
saintentropy 3d96a27
NodeView clean up, comments, and deregister event handlers
saintentropy 3f79235
Inport cleanup, comments, and deregister events
saintentropy e74e8d8
remove BeginInit / EndInit
saintentropy b387f0d
Clean up Outport, add comments, deregister events
saintentropy 3037ffc
Fix test and realing names with old names
saintentropy 98a6a11
Update api docs
saintentropy 3136e36
Fix tests
saintentropy c84d3e4
Fix API doc
saintentropy 3bb8e4b
fIx api doc
saintentropy 0ccf319
First pass at lazy load
saintentropy 10ca6ea
Change to background
saintentropy c6fecdc
Merge branch 'master' of https://github.com/DynamoDS/Dynamo into Cach…
zeusongit 5fc3ed3
add missing trigger
zeusongit 7833644
Merge branch 'master' of https://github.com/DynamoDS/Dynamo into DYN-…
zeusongit 4ae3ee7
Update NodeView.xaml.cs
zeusongit 9d09c73
reinstate opacity converter
zeusongit dded96f
Apply defer based on node count
zeusongit ef6af98
record node load time in debug
zeusongit 6a6da15
Add user authentication middleware
zeusongit d96130f
Merge branch 'master' of https://github.com/DynamoDS/Dynamo into DYN-…
zeusongit d6a4ac9
deferred load
zeusongit 955df68
Update NodeView.xaml.cs
zeusongit 5c80204
Improve node loading UI and expose loading properties
zeusongit d1fc40f
comments
zeusongit a02d7ef
remove customized nodes
zeusongit 400b8a4
Move the ResourceSet to static field
saintentropy 973a34d
Removed commented out sections
saintentropy 1691e06
typo
saintentropy 9dc24fb
typo
saintentropy 3e651d5
Merge pull request #2 from saintentropy/DYN-8303-2
zeusongit ce53697
Merge branch 'master' of https://github.com/DynamoDS/Dynamo into 8303-t
zeusongit 4de0299
Update NodeView.xaml.cs
zeusongit 9ee2bdd
remove stopwatch
zeusongit d7a7511
Use Path.GetInvalidFileNameChars for node name sanitization
zeusongit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
<UserControl x:Class="Dynamo.Wpf.Controls.NotificationsControl" | ||
<UserControl x:Class="Dynamo.Wpf.Controls.NotificationsControl" | ||
xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation" | ||
xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" | ||
xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006" | ||
|
@@ -35,6 +35,7 @@ | |
<core:NotificationLevelToColorConverter x:Key="NotificationLevelToColorConverter"></core:NotificationLevelToColorConverter> | ||
<core:ZeroToVisibilityCollapsedConverter x:Key="ZeroToVisibilityCollapsedConverter" /> | ||
<converters:EmptyStringToHiddenConverter x:Key="EmptyStringToHiddenConverter" /> | ||
<converters:BoolToVisibilityConverter x:Key="BoolToVisibilityConverter" /> | ||
<converters:LinterIssueCountToVisibilityConverter x:Key="LinterIssueCountToVisibilityConverter" /> | ||
<ResourceDictionary.MergedDictionaries> | ||
<ui:SharedResourceDictionary Source="{x:Static ui:SharedDictionaryManager.DynamoConvertersDictionaryUri}" /> | ||
|
@@ -45,6 +46,7 @@ | |
|
||
<Grid HorizontalAlignment="Stretch" VerticalAlignment="Center"> | ||
<Grid.ColumnDefinitions> | ||
<ColumnDefinition Width="Auto" /> | ||
<ColumnDefinition Width="Auto" /> | ||
<ColumnDefinition Width="Auto" /> | ||
<ColumnDefinition Width="*" /> | ||
|
@@ -128,8 +130,51 @@ | |
</ItemsControl.ItemsPanel> | ||
</ItemsControl> | ||
|
||
|
||
<Border Style="{StaticResource FooterNotificationItemStyle}" Grid.Column="2" | ||
Visibility="{Binding HomeSpaceViewModel.NodesLoading, Converter={StaticResource BoolToVisibilityConverter}}"> | ||
<StackPanel | ||
Orientation="Horizontal" Margin="5,0" | ||
VerticalAlignment="Center"> | ||
<Image Name="downloadingIcon" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The progress spinner lacks an automation name or tooltip for screen readers. Consider adding Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||
Width="16" | ||
Height="16" | ||
VerticalAlignment="Center" | ||
RenderTransformOrigin="0.5,0.5" | ||
Source="/DynamoCoreWpf;component/UI/Images/Progress circle.png" | ||
Visibility="Visible"> | ||
<Image.RenderTransform> | ||
<RotateTransform x:Name="AnimatedRotateTransform" Angle="0" /> | ||
</Image.RenderTransform> | ||
<Image.Triggers> | ||
<EventTrigger RoutedEvent="Window.Loaded"> | ||
<BeginStoryboard> | ||
<Storyboard> | ||
<DoubleAnimation By="10" | ||
FillBehavior="Stop" | ||
RepeatBehavior="Forever" | ||
Storyboard.TargetName="AnimatedRotateTransform" | ||
Storyboard.TargetProperty="Angle" | ||
To="360" | ||
Duration="0:0:0.5" /> | ||
</Storyboard> | ||
</BeginStoryboard> | ||
</EventTrigger> | ||
</Image.Triggers> | ||
</Image> | ||
<TextBlock Margin="10,0" | ||
Foreground="White" VerticalAlignment="Center"> | ||
<Run Text="Loading nodes: " /> | ||
<Run Text="{Binding HomeSpaceViewModel.LoadedNodesCount, Mode=OneWay}" /> | ||
<Run Text="/" /> | ||
<Run Text="{Binding HomeSpaceViewModel.Nodes.Count, Mode=OneWay}" /> | ||
</TextBlock> | ||
</StackPanel> | ||
</Border> | ||
|
||
|
||
<StackPanel Orientation="Horizontal" | ||
Grid.Column="2" | ||
Grid.Column="3" | ||
HorizontalAlignment="Right" | ||
VerticalAlignment="Center" | ||
Margin="30,0" | ||
|
@@ -156,4 +201,4 @@ | |
</StackPanel> | ||
|
||
</Grid> | ||
</UserControl> | ||
</UserControl> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Use
x:Name
instead ofName
in XAML to ensure uniqueness across templates and avoid potential conflicts.Copilot uses AI. Check for mistakes.