Skip to content

Conversation

@ivaylo-matov
Copy link
Contributor

Purpose

This PR addresses DYN-8072 where users were not always prompted to save changes when opening a new graph from the Recent Files section.

Changes Implemented:

  • Ensured that AskUserToSaveWorkspaceOrCancel is called when opening a new graph.
  • Updated HasUnsavedChanges handling.
    Now, after the user confirms saving or discarding changes, workspace.HasUnsavedChanges is properly set.

Expected Behavior After the Fix:

  • If the current graph has unsaved changes, the user will always be prompted before opening a new graph.
  • If the user chooses to save or discard changes, HasUnsavedChanges is correctly updated.

DYN-8072-Fix

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Changes Implemented:

  • Ensured that AskUserToSaveWorkspaceOrCancel is called when opening a new graph.
  • Updated HasUnsavedChanges handling.
    Now, after the user confirms saving or discarding changes, workspace.HasUnsavedChanges is properly set.

Expected Behavior After the Fix:

  • If the current graph has unsaved changes, the user will always be prompted before opening a new graph.
  • If the user chooses to save or discard changes, HasUnsavedChanges is correctly updated.

Reviewers

@QilongTang
@reddyashish

FYIs

@dnenov
@achintyabhat

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8072

@zeusongit zeusongit added this to the 3.5 milestone Mar 3, 2025
@zeusongit
Copy link
Contributor

@ivaylo-matov Can you address the conflicts? Thanks.

…r-unsaved-changes-when-open-file-from-home-tab
@ivaylo-matov
Copy link
Contributor Author

@ivaylo-matov Can you address the conflicts? Thanks.

done! Thanks!

@reddyashish reddyashish merged commit 25e061c into DynamoDS:master Mar 4, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants