Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update FastImageViewManager.java #423

Merged
merged 1 commit into from
Sep 27, 2021
Merged

Update FastImageViewManager.java #423

merged 1 commit into from
Sep 27, 2021

Conversation

hungvxt
Copy link
Contributor

@hungvxt hungvxt commented Mar 5, 2019 •
edited
Loading

Dear DylanVann,

First of all, I would like to say thank you for your very good library. It's so great.

The next thing, I create this pull request to fix an exception (IMHO) that I faced with my project.

The exception is: **java.lang.IllegalArgumentException** 
The exception detail:
com.facebook.react.bridge.JSApplicationIllegalArgumentException: 
  at com.facebook.react.uimanager.ViewManagersPropertyCache$PropSetter.updateViewProp (ViewManagersPropertyCache.java:95)
  at com.facebook.react.uimanager.ViewManagerPropertyUpdater$FallbackViewManagerSetter.setProperty (ViewManagerPropertyUpdater.java:132)
  at com.facebook.react.uimanager.ViewManagerPropertyUpdater.updateProps (ViewManagerPropertyUpdater.java:51)
  at com.facebook.react.uimanager.ViewManager.updateProperties (ViewManager.java:32)
  at com.facebook.react.uimanager.NativeViewHierarchyManager.updateProperties (NativeViewHierarchyManager.java:138)
  at com.facebook.react.uimanager.UIViewOperationQueue$UpdatePropertiesOperation.execute (UIViewOperationQueue.java:95)
  at com.facebook.react.uimanager.UIViewOperationQueue$1.run (UIViewOperationQueue.java:894)
  at com.facebook.react.uimanager.UIViewOperationQueue.flushPendingBatches (UIViewOperationQueue.java:1001)
  at com.facebook.react.uimanager.UIViewOperationQueue.access$2400 (UIViewOperationQueue.java:46)
  at com.facebook.react.uimanager.UIViewOperationQueue$DispatchUIFrameCallback.doFrameGuarded (UIViewOperationQueue.java:1061)
  at com.facebook.react.uimanager.GuardedFrameCallback.doFrame (GuardedFrameCallback.java:29)
  at com.facebook.react.modules.core.ReactChoreographer$ReactChoreographerDispatcher.doFrame (ReactChoreographer.java:134)
  at com.facebook.react.modules.core.ChoreographerCompat$FrameCallback$1.doFrame (ChoreographerCompat.java:105)
  at android.view.Choreographer$CallbackRecord.run (Choreographer.java:909)
  at android.view.Choreographer.doCallbacks (Choreographer.java:723)
  at android.view.Choreographer.doFrame (Choreographer.java:655)
  at android.view.Choreographer$FrameDisplayEventReceiver.run (Choreographer.java:897)
  at android.os.Handler.handleCallback (Handler.java:789)
  at android.os.Handler.dispatchMessage (Handler.java:98)
  at android.os.Looper.loop (Looper.java:164)
  at android.app.ActivityThread.main (ActivityThread.java:6944)
  at java.lang.reflect.Method.invoke (Native Method)
  at com.android.internal.os.Zygote$MethodAndArgsCaller.run (Zygote.java:327)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1374)
Caused by: java.lang.reflect.InvocationTargetException: 
  at java.lang.reflect.Method.invoke (Native Method)
  at com.facebook.react.uimanager.ViewManagersPropertyCache$PropSetter.updateViewProp (ViewManagersPropertyCache.java:83)
Caused by: java.lang.IllegalArgumentException: 
  at com.bumptech.glide.request.target.ViewTarget.getRequest (**ViewTarget.java:265**)
  at com.bumptech.glide.RequestManager.untrack (RequestManager.java:597)
  at com.bumptech.glide.RequestManager.untrackOrDelegate (RequestManager.java:571)
  at com.bumptech.glide.RequestManager.clear (RequestManager.java:559)
  at com.bumptech.glide.RequestManager.clear (RequestManager.java:544)
  at com.dylanvann.fastimage.FastImageViewManager.setSrc (**FastImageViewManager.java:78**)

Best Regard.
Hung Vo

@codecov
Copy link

codecov bot commented Mar 5, 2019

Codecov Report

Merging #423 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #423   +/-   ##
=======================================
  Coverage   94.11%   94.11%           
=======================================
  Files           1        1           
  Lines          17       17           
=======================================
  Hits           16       16           
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89c0e2e...834ffd8. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 5, 2019 •
edited
Loading

Codecov Report

Merging #423 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #423   +/-   ##
=======================================
  Coverage   94.11%   94.11%           
=======================================
  Files           1        1           
  Lines          17       17           
=======================================
  Hits           16       16           
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89c0e2e...834ffd8. Read the comment docs.

@ivanmoskalev ivanmoskalev mentioned this pull request Apr 30, 2019
Closed
@DylanVann DylanVann merged commit a7a8643 into DylanVann:main Sep 27, 2021
github-actions bot pushed a commit that referenced this pull request Sep 27, 2021
@semantic-release-bot
release(version): Release 8.5.11 [skip ci]
4d8c749 
## [8.5.11](v8.5.10...v8.5.11) (2021-09-27)

### Bug Fixes

* null exception in FastImageViewManager.java ([#423](#423)) ([a7a8643](a7a8643))
@github-actions
Copy link

🎉 This PR is included in version 8.5.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

anaisbetts added a commit to chatterbugapp/react-native-fast-image that referenced this pull request Sep 28, 2021
@anaisbetts
Merge remote-tracking branch 'upstream/main'
2257778 
* upstream/main:
  release(version): Release 8.5.11 [skip ci]
  fix: null exception in FastImageViewManager.java (DylanVann#423)
  release(version): Release 8.5.10 [skip ci]
  chore: convert examples to hooks (DylanVann#830)
  release(version): Release 8.5.9 [skip ci]
  fix: FastImage extends ViewProps (DylanVann#829)
  ci: update CI and (re)enable coverage (DylanVann#826) [skip ci]
  release(version): Release 8.5.8 [skip ci]
  docs: fix gifs
  release(version): Release 8.5.7 [skip ci]
  chore: upgrade example to react-native@0.65.1
  release(version): Release 8.5.6 [skip ci]
  fix: make corresponding flow file for .cjs file
alicayan008 pushed a commit to alicayan008/ReactNative-fast-image that referenced this pull request Jul 4, 2023
@semantic-release-bot
release(version): Release 8.5.11 [skip ci]
8d7bd59 
## [8.5.11](DylanVann/react-native-fast-image@v8.5.10...v8.5.11) (2021-09-27)

### Bug Fixes

* null exception in FastImageViewManager.java ([#423](DylanVann/react-native-fast-image#423)) ([a7a8643](DylanVann/react-native-fast-image@a7a8643))
billouboq pushed a commit to beedeez/react-native-fast-image that referenced this pull request Aug 6, 2023
@hungvxt @billouboq
fix: null exception in FastImageViewManager.java (DylanVann#423)
c911296
tungxuan1656 pushed a commit to tungxuan1656/react-native-fast-image that referenced this pull request Dec 26, 2023
@hungvxt @tungdoanemddi
fix: null exception in FastImageViewManager.java (DylanVann#423)
1f8616c
tungxuan1656 pushed a commit to tungxuan1656/react-native-fast-image that referenced this pull request Dec 26, 2023
@semantic-release-bot @tungdoanemddi
release(version): Release 8.5.11 [skip ci]
e770833 
## [8.5.11](DylanVann/react-native-fast-image@v8.5.10...v8.5.11) (2021-09-27)

### Bug Fixes

* null exception in FastImageViewManager.java ([DylanVann#423](DylanVann#423)) ([a7a8643](DylanVann@a7a8643))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hungvxt @DylanVann