Skip to content

Commit e070c83

Browse files
committed
revert all test changes
1 parent 7a36b24 commit e070c83

File tree

7 files changed

+115
-131
lines changed

7 files changed

+115
-131
lines changed

MixpanelDemo/MixpanelDemoMacTests/MixpanelBaseTests.swift

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -104,19 +104,19 @@ class MixpanelBaseTests: XCTestCase, MixpanelDelegate {
104104
}
105105

106106
func eventQueue(token: String) -> Queue {
107-
return MixpanelPersistence.init(instanceName: token).loadEntitiesInBatch(type: .events)
107+
return MixpanelPersistence.init(token: token).loadEntitiesInBatch(type: .events)
108108
}
109109

110110
func peopleQueue(token: String) -> Queue {
111-
return MixpanelPersistence.init(instanceName: token).loadEntitiesInBatch(type: .people)
111+
return MixpanelPersistence.init(token: token).loadEntitiesInBatch(type: .people)
112112
}
113113

114114
func unIdentifiedPeopleQueue(token: String) -> Queue {
115-
return MixpanelPersistence.init(instanceName: token).loadEntitiesInBatch(type: .people, flag: PersistenceConstant.unIdentifiedFlag)
115+
return MixpanelPersistence.init(token: token).loadEntitiesInBatch(type: .people, flag: PersistenceConstant.unIdentifiedFlag)
116116
}
117117

118118
func groupQueue(token: String) -> Queue {
119-
return MixpanelPersistence.init(instanceName: token).loadEntitiesInBatch(type: .groups)
119+
return MixpanelPersistence.init(token: token).loadEntitiesInBatch(type: .groups)
120120
}
121121

122122
func flushAndWaitForTrackingQueue(_ mixpanel: MixpanelInstance) {

MixpanelDemo/MixpanelDemoTests/MixpanelAutomaticEventsTests.swift

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ class MixpanelAutomaticEventsTests: MixpanelBaseTests {
3030
XCTAssertNotNil(event, "Should have an event")
3131
XCTAssertEqual(event?["event"] as? String, "$ae_session", "should be app session event")
3232
XCTAssertNotNil((event?["properties"] as? [String: Any])?["$ae_session_length"], "should have session length")
33-
removeDBFileForInstance(testMixpanel)
33+
removeDBfile(testMixpanel.apiToken)
3434
}
3535

3636
func testKeepAutomaticEventsIfNetworkNotAvailable() {
@@ -43,7 +43,7 @@ class MixpanelAutomaticEventsTests: MixpanelBaseTests {
4343
let event = eventQueue(token: testMixpanel.apiToken).last
4444
XCTAssertTrue(eventQueue(token: testMixpanel.apiToken).count == 2, "automatic events should be accumulated if device is offline")
4545
XCTAssertEqual(event?["event"] as? String, "$ae_session", "should be app session event")
46-
removeDBFileForInstance(testMixpanel)
46+
removeDBfile(testMixpanel.apiToken)
4747
}
4848

4949
func testDiscardAutomaticEventsIftrackAutomaticEventsEnabledIsFalse() {
@@ -53,7 +53,7 @@ class MixpanelAutomaticEventsTests: MixpanelBaseTests {
5353
with: Notification(name: Notification.Name(rawValue: "test")))
5454
waitForTrackingQueue(testMixpanel)
5555
XCTAssertTrue(eventQueue(token: testMixpanel.apiToken).count == 0, "automatic events should not be tracked")
56-
removeDBFileForInstance(testMixpanel)
56+
removeDBfile(testMixpanel.apiToken)
5757
}
5858

5959
func testFlushAutomaticEventsIftrackAutomaticEventsEnabledIsTrue() {
@@ -66,7 +66,7 @@ class MixpanelAutomaticEventsTests: MixpanelBaseTests {
6666

6767
flushAndWaitForTrackingQueue(testMixpanel)
6868
XCTAssertTrue(eventQueue(token: testMixpanel.apiToken).count == 0, "automatic events should be flushed")
69-
removeDBFileForInstance(testMixpanel)
69+
removeDBfile(testMixpanel.apiToken)
7070
}
7171

7272
func testUpdated() {
@@ -89,7 +89,6 @@ class MixpanelAutomaticEventsTests: MixpanelBaseTests {
8989
mp2.minimumSessionDuration = 0;
9090
waitForTrackingQueue(mp2)
9191
XCTAssertEqual(eventQueue(token: mp2.apiToken).count, 0, "First app open should not be tracked again")
92-
removeDBFileForInstance(mp)
9392
}
9493

9594
func testAutomaticEventsInMultipleInstances() {
@@ -125,7 +124,7 @@ class MixpanelAutomaticEventsTests: MixpanelBaseTests {
125124
let otherAppSessionEvent = eventQueue(token: mp2.apiToken).last
126125
XCTAssertEqual(otherAppSessionEvent?["event"] as? String, "$ae_session", "should be app session event")
127126
XCTAssertNotNil((otherAppSessionEvent?["properties"] as? [String: Any])?["$ae_session_length"], "should have session length")
128-
removeDBFileForInstance(mp)
129-
removeDBFileForInstance(mp2)
127+
removeDBfile(mp.apiToken)
128+
removeDBfile(mp2.apiToken)
130129
}
131130
}

MixpanelDemo/MixpanelDemoTests/MixpanelBaseTests.swift

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ class MixpanelBaseTests: XCTestCase, MixpanelDelegate {
2929
super.tearDown()
3030
}
3131

32-
func removeDBFileForToken(_ token: String? = nil) {
32+
func removeDBfile(_ token: String? = nil) {
3333
do {
3434
let fileManager = FileManager.default
3535

@@ -47,12 +47,6 @@ class MixpanelBaseTests: XCTestCase, MixpanelDelegate {
4747
}
4848
}
4949

50-
func removeDBFileForInstance(_ instance: MixpanelInstance? = nil) {
51-
instance?.mixpanelPersistence.mpdb.close()
52-
let token = instance?.name
53-
removeDBFileForToken(token)
54-
}
55-
5650
func dbFilePath(_ token: String? = nil) -> String {
5751
let manager = FileManager.default
5852
#if os(iOS)
@@ -64,7 +58,7 @@ class MixpanelBaseTests: XCTestCase, MixpanelDelegate {
6458
return ""
6559
}
6660

67-
guard let urlUnwrapped = url?.appendingPathComponent("\(apiToken)_MPDB.sqlite").path else {
61+
guard let urlUnwrapped = url?.appendingPathComponent("\(token ?? apiToken)_MPDB.sqlite").path else {
6862
return ""
6963
}
7064
return urlUnwrapped

0 commit comments

Comments
 (0)