Fixed minor lint warnings

Author: Oleh

ExampleMVVM/Data/PersistentStorages/CoreDataStorage/CoreDataStorage.swift

@@ -25,11 +25,11 @@ final class CoreDataStorage {
     // MARK: - Core Data stack
     private lazy var persistentContainer: NSPersistentContainer = {
         let container = NSPersistentContainer(name: "CoreDataStorage")
-        container.loadPersistentStores(completionHandler: { (_, error) in
+        container.loadPersistentStores { _, error in
             if let error = error as NSError? {
                 fatalError("Unresolved error \(error), \(error.userInfo)")
             }
-        })
+        }
         return container
     }()
 
@@ -97,8 +97,8 @@ extension CoreDataStorage: MoviesQueriesStorage {
                                                     ascending: false)]
         let resut = try context.fetch(request)
         resut.filter { $0.query == query.query }.forEach { context.delete($0) }
-        if resut.count > maxStorageLimit-1 {
-            Array(resut[maxStorageLimit-1..<resut.count]).forEach { context.delete($0) }
+        if resut.count > maxStorageLimit - 1 {
+            Array(resut[maxStorageLimit - 1..<resut.count]).forEach { context.delete($0) }
         }
     }
 }

ExampleMVVM/Infrastructure/Network/Endpoint.swift

@@ -69,7 +69,7 @@ extension Requestable {
         let baseURL = config.baseURL.absoluteString.last != "/" ? config.baseURL.absoluteString + "/" : config.baseURL.absoluteString
         let endpoint = isFullPath ? path : baseURL.appending(path)
 
-        guard var urlComponents = URLComponents(string: endpoint) else { throw RequestGenerationError.components}
+        guard var urlComponents = URLComponents(string: endpoint) else { throw RequestGenerationError.components }
         var urlQueryItems = [URLQueryItem]()
 
         queryParameters.forEach {
@@ -88,7 +88,7 @@ extension Requestable {
         let url = try self.url(with: config)
         var urlRequest = URLRequest(url: url)
         var allHeaders: [String: String] = config.headers
-        headerParamaters.forEach({ allHeaders.updateValue($1, forKey: $0) })
+        headerParamaters.forEach { allHeaders.updateValue($1, forKey: $0) }
 
         if !bodyParamaters.isEmpty {
             urlRequest.httpBody = encodeBody(bodyParamaters: bodyParamaters, bodyEncoding: bodyEncoding)

ExampleMVVM/Infrastructure/Network/NetworkService.swift

@@ -42,7 +42,7 @@ extension URLSessionTask: Cancellable { }
 extension URLSession: NetworkSession {
     public func loadData(from request: URLRequest,
                          completionHandler: @escaping (Data?, URLResponse?, Error?) -> Void) -> Cancellable {
-        let task = dataTask(with: request) { (data, response, error) in
+        let task = dataTask(with: request) { data, response, error in
             completionHandler(data, response, error)
         }
         task.resume()
@@ -68,7 +68,7 @@ final public class DefaultNetworkService {
 
     private func request(request: URLRequest, completion: @escaping (Result<Data?, NetworkError>) -> Void) -> Cancellable {
 
-        let sessionDataTask = session.loadData(from: request) { [weak self] (data, response, requestError) in
+        let sessionDataTask = session.loadData(from: request) { [weak self] data, response, requestError in
             var error: NetworkError
             if let requestError = requestError {
 
@@ -139,7 +139,7 @@ final public class DefaultNetworkErrorLogger: NetworkErrorLogger {
     public func log(responseData data: Data?, response: URLResponse?) {
         #if DEBUG
         guard let data = data else { return }
-        if let dataDict =  try? JSONSerialization.jsonObject(with: data, options: []) as? [String: Any] {
+        if let dataDict = try? JSONSerialization.jsonObject(with: data, options: []) as? [String: Any] {
             print("responseData: \(String(describing: dataDict))")
         }
         #endif

ExampleMVVM/Presentation/MoviesScene/MovieDetails/View/MovieDetailsViewController.swift

@@ -12,8 +12,8 @@ final class MovieDetailsViewController: UIViewController, StoryboardInstantiable
 
     private static let fadeTransitionDuration: CFTimeInterval = 0.4
 
-    @IBOutlet private weak var posterImageView: UIImageView!
-    @IBOutlet private weak var overviewTextView: UITextView!
+    @IBOutlet private var posterImageView: UIImageView!
+    @IBOutlet private var overviewTextView: UITextView!
 
     var viewModel: MovieDetailsViewModel!
 

ExampleMVVM/Presentation/MoviesScene/MoviesList/View/MoviesListTableView/Cells/MoviesListItemCell.swift

@@ -12,10 +12,10 @@ final class MoviesListItemCell: UITableViewCell {
     static let reuseIdentifier = String(describing: MoviesListItemCell.self)
     static let height = CGFloat(130)
 
-    @IBOutlet private weak var titleLabel: UILabel!
-    @IBOutlet private weak var dateLabel: UILabel!
-    @IBOutlet private weak var overviewLabel: UILabel!
-    @IBOutlet private weak var posterImageView: UIImageView!
+    @IBOutlet private var titleLabel: UILabel!
+    @IBOutlet private var dateLabel: UILabel!
+    @IBOutlet private var overviewLabel: UILabel!
+    @IBOutlet private var posterImageView: UIImageView!
 
     private var viewModel: MoviesListItemViewModel! { didSet { unbind(from: oldValue) } }
 

ExampleMVVM/Presentation/MoviesScene/MoviesList/View/MoviesListViewController.swift

@@ -9,12 +9,12 @@ import UIKit
 
 final class MoviesListViewController: UIViewController, StoryboardInstantiable, Alertable {
 
-    @IBOutlet private weak var contentView: UIView!
-    @IBOutlet private weak var moviesListContainer: UIView!
-    @IBOutlet private weak var suggestionsListContainer: UIView!
-    @IBOutlet private weak var searchBarContainer: UIView!
-    @IBOutlet private weak var loadingView: UIActivityIndicatorView!
-    @IBOutlet private weak var emptyDataLabel: UILabel!
+    @IBOutlet private var contentView: UIView!
+    @IBOutlet private var moviesListContainer: UIView!
+    @IBOutlet private var suggestionsListContainer: UIView!
+    @IBOutlet private var searchBarContainer: UIView!
+    @IBOutlet private var loadingView: UIActivityIndicatorView!
+    @IBOutlet private var emptyDataLabel: UILabel!
 
     private(set) var viewModel: MoviesListViewModel!
     private var moviesListViewControllersFactory: MoviesListViewControllersFactory!

ExampleMVVM/Presentation/MoviesScene/MoviesList/ViewModel/MoviesListViewModel.swift

@@ -77,8 +77,10 @@ final class DefaultMoviesListViewModel: MoviesListViewModel {
     private func appendPage(moviesPage: MoviesPage) {
         self.currentPage = moviesPage.page
         self.totalPageCount = moviesPage.totalPages
-        self.items.value = items.value + moviesPage.movies.map { DefaultMoviesListItemViewModel(movie: $0,
-                                                                                                posterImagesRepository: posterImagesRepository) }
+        self.items.value = items.value + moviesPage.movies.map {
+            DefaultMoviesListItemViewModel(movie: $0,
+                                           posterImagesRepository: posterImagesRepository)
+        }
     }
 
     private func resetPages() {

ExampleMVVM/Presentation/MoviesScene/MoviesQueriesList/View/UIKit/Cells/MoviesQueriesItemCell.swift

@@ -10,7 +10,7 @@ import UIKit
 final class MoviesQueriesItemCell: UITableViewCell {
 
     static let reuseIdentifier = String(describing: MoviesQueriesItemCell.self)
-    @IBOutlet private weak var titleLabel: UILabel!
+    @IBOutlet private var titleLabel: UILabel!
 
     func fill(with suggestion: MoviesQueryListItemViewModel) {
         self.titleLabel.text = suggestion.query

ExampleMVVM/Presentation/Utils/Observable.swift

@@ -39,4 +39,3 @@ public final class Observable<Value> {
         }
     }
 }
-

ExampleMVVMTests/Infrastructure/Network/NetworkServiceTests.swift

@@ -230,8 +230,8 @@ class NetworkServiceTests: XCTestCase {
 
         //then
         wait(for: [expectation], timeout: 0.1)
-        XCTAssertTrue(networkErrorLogger.loggedErrors.contains(where: {
+        XCTAssertTrue(networkErrorLogger.loggedErrors.contains {
             ($0 as NSError).code == NSURLErrorNotConnectedToInternet
-        }))
+        })
     }
 }