Refactor number to maxCount

Author: kudoleh

ExampleMVVM/Data/PersistentStorages/CoreDataStorage/CoreDataMoviesQueriesStorage.swift

@@ -62,14 +62,14 @@ final class CoreDataMoviesQueriesStorage {
 
 extension CoreDataMoviesQueriesStorage: MoviesQueriesStorage {
 
-    func fetchRecentsQueries(number: Int, completion: @escaping (Result<[MovieQuery], Error>) -> Void) {
+    func fetchRecentsQueries(maxCount: Int, completion: @escaping (Result<[MovieQuery], Error>) -> Void) {
 
         persistentContainer.performBackgroundTask { context in
             do {
                 let request: NSFetchRequest<MovieQueryEntity> = MovieQueryEntity.fetchRequest()
                 request.sortDescriptors = [NSSortDescriptor(key: #keyPath(MovieQueryEntity.createdAt),
                                                             ascending: false)]
-                request.fetchLimit = number
+                request.fetchLimit = maxCount
                 let resut = try context.fetch(request).map(MovieQuery.init)
 
                 completion(.success(resut))

ExampleMVVM/Data/PersistentStorages/MoviesQueriesStorage.swift

@@ -8,6 +8,6 @@
 import Foundation
 
 protocol MoviesQueriesStorage {
-    func fetchRecentsQueries(number: Int, completion: @escaping (Result<[MovieQuery], Error>) -> Void)
+    func fetchRecentsQueries(maxCount: Int, completion: @escaping (Result<[MovieQuery], Error>) -> Void)
     func saveRecentQuery(query: MovieQuery, completion: @escaping (Result<MovieQuery, Error>) -> Void)
 }

ExampleMVVM/Data/PersistentStorages/UserDefaultsStorage/UserDefaultsMoviesQueriesStorage.swift

@@ -40,11 +40,11 @@ final class UserDefaultsMoviesQueriesStorage {
 }
 
 extension UserDefaultsMoviesQueriesStorage: MoviesQueriesStorage {
-    func fetchRecentsQueries(number: Int, completion: @escaping (Result<[MovieQuery], Error>) -> Void) {
+    func fetchRecentsQueries(maxCount: Int, completion: @escaping (Result<[MovieQuery], Error>) -> Void) {
         DispatchQueue.global(qos: .userInitiated).async { [weak self] in
             guard let self = self else { return }
             var queries = self.fetchMoviesQuries()
-            queries = queries.count < self.maxStorageLimit ? queries : Array(queries[0..<number])
+            queries = queries.count < self.maxStorageLimit ? queries : Array(queries[0..<maxCount])
             completion(.success(queries))
         }
     }

ExampleMVVM/Data/Repositories/DefaultMoviesQueriesRepository.swift

@@ -21,8 +21,8 @@ final class DefaultMoviesQueriesRepository {
 
 extension DefaultMoviesQueriesRepository: MoviesQueriesRepository {
 
-    func fetchRecentsQueries(number: Int, completion: @escaping (Result<[MovieQuery], Error>) -> Void) {
-        return moviesQueriesPersistentStorage.fetchRecentsQueries(number: number, completion: completion)
+    func fetchRecentsQueries(maxCount: Int, completion: @escaping (Result<[MovieQuery], Error>) -> Void) {
+        return moviesQueriesPersistentStorage.fetchRecentsQueries(maxCount: maxCount, completion: completion)
     }
 
     func saveRecentQuery(query: MovieQuery, completion: @escaping (Result<MovieQuery, Error>) -> Void) {

ExampleMVVM/Domain/Interfaces/Repositories/MoviesQueriesRepository.swift

@@ -8,6 +8,6 @@
 import Foundation
 
 protocol MoviesQueriesRepository {
-    func fetchRecentsQueries(number: Int, completion: @escaping (Result<[MovieQuery], Error>) -> Void)
+    func fetchRecentsQueries(maxCount: Int, completion: @escaping (Result<[MovieQuery], Error>) -> Void)
     func saveRecentQuery(query: MovieQuery, completion: @escaping (Result<MovieQuery, Error>) -> Void)
 }

ExampleMVVM/Domain/UseCases/FetchRecentMovieQueriesUseCase.swift

@@ -11,7 +11,7 @@ import Foundation
 final class FetchRecentMovieQueriesUseCase: UseCase {
 
     struct RequestValue {
-        let number: Int
+        let maxCount: Int
     }
     typealias ResultValue = (Result<[MovieQuery], Error>)
 
@@ -28,7 +28,7 @@ final class FetchRecentMovieQueriesUseCase: UseCase {
     }
 
     func start() -> Cancellable? {
-        moviesQueriesRepository.fetchRecentsQueries(number: requestValue.number) { result in
+        moviesQueriesRepository.fetchRecentsQueries(maxCount: requestValue.maxCount) { result in
             // Note: here self must be strong because we will create use case every time we use it, without holding reference to it
             switch result {
             case .success(let movieQueries):

ExampleMVVM/Presentation/MoviesScene/MoviesQueriesList/ViewModel/MoviesQueryListViewModel.swift

@@ -46,7 +46,7 @@ final class DefaultMoviesQueryListViewModel: MoviesQueryListViewModel {
     }
 
     private func updateMoviesQueries() {
-        let request = FetchRecentMovieQueriesUseCase.RequestValue(number: numberOfQueriesToShow)
+        let request = FetchRecentMovieQueriesUseCase.RequestValue(maxCount: numberOfQueriesToShow)
         let completion: (FetchRecentMovieQueriesUseCase.ResultValue) -> Void = { [weak self] result in
             guard let self = self else { return }
             switch result {

ExampleMVVMTests/Domain/UseCases/SearchMoviesUseCaseTests.swift

@@ -25,7 +25,7 @@ class SearchMoviesUseCaseTests: XCTestCase {
     class MoviesQueriesRepositoryMock: MoviesQueriesRepository {
         var recentQueries: [MovieQuery] = []
 
-        func fetchRecentsQueries(number: Int, completion: @escaping (Result<[MovieQuery], Error>) -> Void) {
+        func fetchRecentsQueries(maxCount: Int, completion: @escaping (Result<[MovieQuery], Error>) -> Void) {
             completion(.success(recentQueries))
         }
         func saveRecentQuery(query: MovieQuery, completion: @escaping (Result<MovieQuery, Error>) -> Void) {
@@ -63,7 +63,7 @@ class SearchMoviesUseCaseTests: XCTestCase {
         }
         // then
         var recents = [MovieQuery]()
-        moviesQueriesRepository.fetchRecentsQueries(number: 1) { result in
+        moviesQueriesRepository.fetchRecentsQueries(maxCount: 1) { result in
             recents = (try? result.get()) ?? []
             expectation.fulfill()
         }
@@ -87,7 +87,7 @@ class SearchMoviesUseCaseTests: XCTestCase {
         }
         // then
         var recents = [MovieQuery]()
-        moviesQueriesRepository.fetchRecentsQueries(number: 1) { result in
+        moviesQueriesRepository.fetchRecentsQueries(maxCount: 1) { result in
             recents = (try? result.get()) ?? []
             expectation.fulfill()
         }