Reject failed login attempts.

Make sure calls to login() return a rejection when there is an error either connecting to the API or invalid credentials. Without this, even if the login API request fails the promise isn't rejected and so in LoginForm.js the .then() statement is called and makes it look like the user is logged in. With this, the promise is rejected and the .catch() is called.

Author: eojthebrave

react-decoupled/src/components/LoginForm.jsx

@@ -41,7 +41,7 @@ const LoginForm = () => {
       .catch((error) => {
         setSubmitting(false);
         setLoggedIn(false);
-        setResult({ error: true, message: 'Login error' });
+        setResult({ error: true, message: `Login error: ${error.message}` });
         console.log('Login error', error);
       });
   };

react-decoupled/src/utils/auth.js

@@ -61,12 +61,13 @@ export function getAuthClient(config = {}) {
       const data = await response.json();
       if (data.error) {
         console.log('Error retrieving token', data);
-        return false;
+        return Promise.reject(new Error(`Error retrieving OAuth token: ${data.error}`));
       }
       return saveToken(data);
     }
     catch (err) {
-      return console.log('API got an error', err);
+      console.log('API got an error', err);
+      return Promise.reject(new Error(`API error: ${err}`));
     }
   };