-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What would it take to upstream this plugin into Administrate? #146
Comments
Hello and thanks for reaching out.
Honestly this project was created due to the fact that Administrate did not support active storage I believe that it will be in better hands being upstreamed into the main gem
I don't have experience in the administrate codebase and I believe if this plugin to be upstreamed into it some support from the maintainers will be needed
I believe it would be.
Deleting attachments is currently hacky in my own opinion but I believe if the plugin moved to administrate better support could be added for such a feature
Same as the point above I believe deleting attachments is a good feature than can be pushed upstream |
@Dreamersoul thank you for your response. That's great news!
Is opening a PR something you'd be interested in taking on, or would you prefer that the Administrate team open one and ping you for review?
Thank you for flagging this, specifically. We'll be sure to incorporate that into administrate itself. Are there other areas that you've found to be difficult to work with, given their constraints? Are there quirks or bugfixes you feel are worth special consideration during a migration upstream? |
Due to work constraints I will not be able to open up a PR, however I can help around with any issue that arises. Please note that @sedubois is a major contributor to the plugin as well.
Testing, the solution we ended up doing was using a rails project embedded in the code base that requires the plugin, and we end up testing that.
Not that I can think of. thanks again. |
As Administrate approaches its first major release (1.0.0), there is an opportunity to be ambitious about its goals.
Active Storage is a built-in Rails framework that is several years old at this point. It has proven to be stable, and as time goes on, more widespread.
Is this plugin's team of maintainers interested in upstreaming this plugin's capabilities into Administrate?
If you are, what kind of support could the Administrate maintainers provide to assist in the process?
Would the plugin be suitable to be upstreamed in its entirety?
Are there specialized features or capabilities the team would like to keep in the plugin?
Is there a subset of features, patterns, or pieces of architecture that could be pushed upstream to enable specialization in the plugin?
The text was updated successfully, but these errors were encountered: