fix(shim): fix uncaught error on asking devicename

Author: DrSensor

package-lock.json

@@ -47,7 +47,6 @@
 		"rollup-plugin-node-resolve": "^4.0.0",
 		"rollup-plugin-prettier": "^0.5.0",
 		"rollup-plugin-run": "git+https://github.com/DrSensor/rollup-plugin-run.git",
-		"rollup-plugin-shim": "^1.0.0",
 		"rollup-plugin-typescript2": "^0.18.1",
 		"shx": "^0.3.2",
 		"standard-version": "^4.4.0",
@@ -113,7 +112,7 @@
 		"postpack": "rm -f oclif.manifest.json",
 		"posttest": "tslint -p . -t stylish",
 		"prebuild": "(shx rm -r dist .rpt2_cache types) || true",
-		"prepack": "rm -rf dist && tsc -b && oclif-dev manifest && oclif-dev readme",
+		"prepack": "tsc -b && oclif-dev manifest && oclif-dev readme",
 		"prepublishOnly": "npm run build",
 		"prestart": "npm run prebuild",
 		"pretest": "npm run build",

package.json

@@ -41,7 +41,7 @@ const configure = ({input, output, watch, ...others}) => ({
 	input,
 	output: Object.assign({
 		format: "cjs",
-		exports: "default"
+		exports: "named"
 	}, output),
 	experimentalCodeSplitting: true,
 	watch: {clearScreen: false},
@@ -55,9 +55,6 @@ const configure = ({input, output, watch, ...others}) => ({
 			readline: resolve("./src/shim-readline")
 			// 🤔 I'm still uncertain if I need to shim the readline or the stdin/stdout
 		}),
-		shim({
-			os: "export const hostname = () => require('byteballcore/conf.js').deviceName"
-		}),
 		babel(),
 		nodeResolve(),
 		commonjs({ignore: id => id !== "readline"}),

rollup.config.js

@@ -1,3 +1,4 @@
+import conf from 'byteballcore/conf'
 import {ReadLineOptions} from 'readline'
 
 import {bot, Question} from './event-handler'
@@ -12,7 +13,10 @@ export function createInterface(_options: ReadLineOptions) {
     question(query: string, answering: (response: string | void) => void) {
       // #region helpers
       query = query.toLocaleLowerCase()
-      const on = (event: Question) => Promise.resolve(bot.onAsking[event]!())
+      const on = (event: Question) => {
+        const cb = bot.onAsking[event]
+        return Promise.resolve(cb ? cb() : conf.devicename)
+      }
       const questionIncludes = (keywords: string[]) => keywords.every(keyword => query.includes(keyword))
       // #endregion helpers
 

src/shim-readline.ts

@@ -13,10 +13,6 @@ declare module 'headless-byteball' {
   export const issueChangeAddressAndSendPayment: Wallet.issueChangeAddressAndSendPayment
 }
 
-declare module 'byteballcore/conf' {
-  export const deviceName: string
-}
-
 interface Device {
   sendMessageToDevice(
     device_address: string,