Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map enums by name instead of using toString() (#52) #729

Merged
merged 1 commit into from
Nov 22, 2018
Merged

Map enums by name instead of using toString() (#52) #729

merged 1 commit into from
Nov 22, 2018

Conversation

diegov
Copy link
Contributor

@diegov diegov commented Nov 14, 2018

Issue link

    [ISSUE: 52] Map with name() and valueOf(...) for Enums in EnumConverter

Purpose

Allow enums to map correctly even in the case of overriden toString methods

Approach

Implement special case EnumConverter ckass when source object is enum, using Enum::name.

Open Questions and Pre-Merge TODOs

  • Issue created
  • Unit tests pass
  • Documentation updated
  • Travis build passed

@diegov diegov mentioned this pull request Nov 14, 2018
Closed
@garethahealy garethahealy merged commit 007bdfc into DozerMapper:master Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diegov @garethahealy