Updated Window Moving Handler #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added ToVector2I() for Vector2.
Changed from Panel to Control Internalized Moving Window to said control, instead of having it on the WindowPanelContainer. Moved to GuiInput to handle capturing of Mouse Button events, and toggling on/off grabbing the DraggablePanel. Used _Process to directly move the main window.
Updated UI Elements to use new DraggablePanel content. On Windows with Close Buttons, placed DraggablePanel inside of HBoxContainer, and placed an Empty Control where the Close Button would be, ensuring enough space to allow Mouse to fully interact with the Close Button. Ensured that DraggablePanel captures Mouse Inputs, while the Empty Control, will ignore them.
Owner
|
Hey! I really appreciate your PR, it's the first external contribution for the project. I'm sorry for taking long to respond, I was right in the process of moving. But here I am. I tested the code on the branch. While it does seem to fix jittering on 1x, it's causing some weird behaviour on 2x size mode: Kapture.2025-08-05.at.12.21.59.mp4It might not be worth fixing this for now. I am restarting development for this project as of this week, and one of my immediate goals is getting actual OS windows instead of a canvas with transparency. By then - the structure will look completely different. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Window Moving behavior to use DraggablePanel to allow moving the full window from within the DraggablePanel, instead of the WindowPanelContainer. Fixes issue where Moving the window would jitter, and not move properly with the window, due to multiple signal execution, causing jitter to occur, and offset to constantly be set.