Skip to content

Update Var aggregation #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Update Var aggregation #268

merged 1 commit into from
Sep 9, 2024

Conversation

SvenKlaassen
Copy link
Member

@SvenKlaassen SvenKlaassen commented Sep 9, 2024

Description

Change variance aggregation to scaled level (scaled variances are aggregated instead of applying the rescaling afterwards).
Enable the option to apply different scalings at different repretitions in the utilities (not used in the current implementation).

Comments

The different scaling are not necessary in the DoubleML class since all the scalings are supposed to be of the same size.
This might be relevant for future RDD implmentations.

PR Checklist

  • The title of the pull request summarizes the changes made.
  • The PR contains a detailed description of all changes and additions.
  • References to related issues or PRs are added.
  • The code passes all (unit) tests.
  • Enhancements or new feature are equipped with unit tests.
  • The changes adhere to the PEP8 standards.

@SvenKlaassen SvenKlaassen merged commit 31f7388 into main Sep 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants