fix error when git config log.abbrevcommit=true #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the git config setting log.abbrevcommit is set to true then when you click on a file in the history view to see the details you get an error. The source of the error is from the git.viewFileCommitDetails callback and is
TypeError: Cannot set property 'previousSha1' of undefined.It appears that the full SHA1 is being passed into the function but is trying to compare it to an abbreviated SHA1 from a call to git log. I solved this by adding the --no-abbrev-commit argument to the call to git log which overrides the log.abbrevcommit setting.