Skip to content

feat: configure logging correctly using logrus #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 17, 2022
Merged

feat: configure logging correctly using logrus #14

merged 5 commits into from
Feb 17, 2022

Conversation

xoanmm
Copy link
Contributor

@xoanmm xoanmm commented Feb 15, 2022

No description provided.

@xoanmm xoanmm self-assigned this Feb 15, 2022
@xoanmm xoanmm requested review from alv91, a team and MatteoManzoni and removed request for a team February 16, 2022 16:10
patrykwozinski
patrykwozinski approved these changes Feb 17, 2022
View reviewed changes
Copy link
Contributor

@patrykwozinski patrykwozinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid! Thanks, Xoán for your work!

So we can remove the zerolog implementation now :)

@xoanmm xoanmm merged commit 20e8aae into develop Feb 17, 2022
@xoanmm xoanmm deleted the feat/SRE-1297 branch February 17, 2022 15:09
@xoanmm xoanmm mentioned this pull request Feb 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alv91 alv91 alv91 approved these changes

@patrykwozinski patrykwozinski patrykwozinski approved these changes

@MatteoManzoni MatteoManzoni MatteoManzoni approved these changes

Assignees

@xoanmm xoanmm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xoanmm @alv91 @patrykwozinski @MatteoManzoni