Skip to content

Commit cb0dba9

Browse files
committed
Add V8_ENABLE_CHECKS to Debug defines, comment out error when compiling v8 with this flag
1 parent 18111f2 commit cb0dba9

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

common.gypi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@
144144
}],
145145
],
146146
},
147-
'defines': [ 'DEBUG', '_DEBUG' ],
147+
'defines': [ 'DEBUG', '_DEBUG', 'V8_ENABLE_CHECKS' ],
148148
'cflags': [ '-g', '-O0' ],
149149
'conditions': [
150150
['OS in "aix os400"', {

deps/v8/include/v8-local-handle.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -425,7 +425,7 @@ class V8_TRIVIAL_ABI Local : public LocalBase<T>,
425425
// If we're going to perform the type check then we have to check
426426
// that the handle isn't empty before doing the checked cast.
427427
if (that.IsEmpty()) return Local<T>();
428-
T::Cast(that.template value<S>());
428+
// T::Cast(that.template value<S>());
429429
#endif
430430
return Local<T>(LocalBase<T>(that));
431431
}

0 commit comments

Comments
 (0)