Skip to content

Commit b819599

Browse files
authored
Merge pull request byzer-org#1282 from allwefantasy/TRY
fix ds pulgin uninstall
2 parents 2b5d6a8 + 86bd204 commit b819599

2 files changed

Lines changed: 7 additions & 11 deletions

File tree

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@
7070
<mlsql-ps-service-version>1.3.5</mlsql-ps-service-version>
7171
<pyjava-version>0.2.6</pyjava-version>
7272
<delta-plus-version>0.2.0</delta-plus-version>
73-
<mysql-binlog-version>1.0.0-SNAPSHOT</mysql-binlog-version>
73+
<mysql-binlog-version>1.0.0</mysql-binlog-version>
7474
<mlsql-scheduler-version>0.1.0</mlsql-scheduler-version>
7575
</properties>
7676

streamingpro-mlsql/src/main/java/tech/mlsql/ets/PluginCommand.scala

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -277,16 +277,12 @@ object PluginCommand {
277277

278278
}
279279

280-
def removeDS(pluginName: String, className: String, commandName: Option[String], callback: () => Unit) = {
281-
// val dataSource = Class.forName(className).newInstance()
282-
// if (dataSource.isInstanceOf[MLSQLRegistry]) {
283-
// dataSource.asInstanceOf[MLSQLRegistry].unRegister()
284-
// }
285-
// commandName match {
286-
// case Some(alisName) =>
287-
// callback()
288-
// case None =>
289-
// }
280+
def removeDS(pluginName: String, fullFormat: String, shortFormat: Option[String], callback: () => Unit) = {
281+
val dataSource = Class.forName(fullFormat).newInstance()
282+
if (dataSource.isInstanceOf[MLSQLRegistry]) {
283+
dataSource.asInstanceOf[MLSQLRegistry].unRegister()
284+
}
285+
callback()
290286
}
291287

292288
def registerDS(pluginName: String, className: String, commandName: Option[String], callback: () => Unit) = {

0 commit comments

Comments
 (0)