FS2-2955: Update to use plotly 2.35.2 #22
Conversation
chschan
changed the title
JustinCCYap
changed the title
| attrs_name_check( | ||
| sub("[0-9]+$", "", names(p$x$layout)), | ||
| c(names(Schema$layout$layoutAttributes), c("barmode", "bargap", "bargroupgap", "mapType")), | ||
| c(names(Schema$layout$layoutAttributes), c("barmode", "bargap", "bargroupgap", "barcornerradius", "mapType")), |
There was a problem hiding this comment.
Just curious how did you know to change this?
There was a problem hiding this comment.
I changed it for bargroup gap a while ago as well. If you try to use barcornerradius you get an ugly warning. I set option(warning=2) to make it an error and checked the stack trace
There was a problem hiding this comment.
Nice. So that means we could get rounded corners just from this PR?
There was a problem hiding this comment.
Yep, rounded corners will work with this. Is there anything else we needed?
There was a problem hiding this comment.
Would you be able to test out the “between” option for the “layer” setting: https://www.notion.so/displayr/Our-plotly-version-is-old-which-means-that-some-features-are-unavailable-b20b3ebe92354cc583d599f1a78768af?pvs=4#c4bb2c738cd5406787016e71fccdbeae
|
Would it be necessary to update the R plotly library as well or can the 2 be done separately? |
|
What do you mean the R plotly library? Our other flip packages depend on this one (e.g. https://github.com/Displayr/flipStandardCharts/blob/master/DESCRIPTION#L50), so they'll get this change if we merge this in |
|
I am wondering if we should do a sync with plot/plotly.R but their JS bundle is so far behind, it doesn't seem worthwhile. A lot of the changes were with functions we don't use |
|
I was using the term from your description. I meant merge in the commits from the original plotly repo that the fork is based on. So you think it is not worthwhile. I think we should document this perhaps in the README? |
|
The main thing we are missing is changes for compatibility with the updated ggplot2. I'm not familiar with it, but some users might have written some custom code to use it. I feel like we can leave it until someone complains about new features not working? (I feel that change will probably break someone else's code so I want to defer) |
I don't understand much about how ggplot2 works with plotly, how do users write custom code to use it if we haven't updated our ploty repo? |
chschan
force-pushed
the
update-v2.33
branch
from
32d983d to
a05f119
Compare
* Use latest bundle 2.35.2 * Turn off warning for barcornerradius * Add documentation * Only run standard tests * Remove github workflow * Remove travis CI config * Use same circle CI config as other flip packages * Replace with default config * Try to turn off all tests * Stop returning error * Turn off build
2 participants
Updates JS bundle to use the latest version (2.35.2). Note that the original R plotly library is only up to 2.11.1 so we have not synced from there.
Tests running on https://testlord.displayr.com:20344/Status