Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement onboarding #928

Merged
merged 66 commits into from
Apr 21, 2023
Merged

feat: implement onboarding #928

merged 66 commits into from
Apr 21, 2023

Conversation

Victorsitou
Copy link
Member

@Victorsitou Victorsitou commented Feb 9, 2023 •
edited
Loading

Summary

discord/discord-api-docs#5915

thanks to helish_88😈#7777 for helping me :)

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running task lint
    • I have type-checked the code by running task pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@Victorsitou Victorsitou added t: enhancement New feature t: api support Support of Discord API features s: in progress Issue/PR is being worked on s: waiting for api/docs Issue/PR is waiting for API support/documentation labels Feb 9, 2023
@Victorsitou Victorsitou marked this pull request as ready for review February 9, 2023 21:51
@Victorsitou Victorsitou added s: needs review Issue/PR is awaiting reviews and removed s: in progress Issue/PR is being worked on labels Feb 9, 2023
@shiftinv shiftinv self-requested a review February 24, 2023 23:25
shiftinv
shiftinv reviewed Feb 28, 2023
View reviewed changes
Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really appreciate the PR!

A couple more general things, which I've also mentioned in some of the comments:

  • Onboarding audit logs aren't part of the API docs, and two out of the five action types appear to be unused.
  • Bots cannot edit onboarding (currently), meaning parts of the code are unfortunately not usable in practice :/ They should be removed/undocumented for now, while ideally still leaving the possibility to implement them in the future without breaking changes.

disnake/emoji.py Outdated Show resolved Hide resolved
disnake/enums.py Outdated Show resolved Hide resolved
disnake/audit_logs.py Outdated Show resolved Hide resolved
disnake/enums.py Outdated Show resolved Hide resolved
disnake/guild.py Outdated Show resolved Hide resolved
docs/api.rst Outdated Show resolved Hide resolved
docs/api.rst Outdated Show resolved Hide resolved
docs/api.rst Outdated Show resolved Hide resolved
docs/api.rst Outdated Show resolved Hide resolved
tests/test_onboarding.py Outdated Show resolved Hide resolved
shiftinv
shiftinv reviewed Apr 1, 2023
View reviewed changes
Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than the occasional ci errors and these last two comments, lgtm!
I haven't tested everything yet, will approve once that's done

docs/api.rst Outdated Show resolved Hide resolved
disnake/onboarding.py Outdated Show resolved Hide resolved
shiftinv
shiftinv reviewed Apr 2, 2023
View reviewed changes
disnake/onboarding.py Outdated Show resolved Hide resolved
disnake/onboarding.py Outdated Show resolved Hide resolved
shiftinv
shiftinv reviewed Apr 2, 2023
View reviewed changes
disnake/onboarding.py Outdated Show resolved Hide resolved
@Victorsitou @shiftinv
Apply suggestions from code review
adc4b01 
Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com>
Signed-off-by: Victor <67214928+Victorsitou@users.noreply.github.com>
shiftinv
shiftinv approved these changes Apr 3, 2023
View reviewed changes
Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@Victorsitou Victorsitou mentioned this pull request Apr 8, 2023
Open
9 tasks
@onerandomusername onerandomusername removed their request for review April 19, 2023 21:04
@Victorsitou Victorsitou mentioned this pull request Apr 19, 2023
Open
8 tasks
shiftinv
shiftinv reviewed Apr 21, 2023
View reviewed changes
disnake/guild.py Outdated Show resolved Hide resolved
changelog/928.feature.rst Outdated Show resolved Hide resolved
Victorsitou and others added 2 commits April 21, 2023 13:35
@Victorsitou @shiftinv
feat: rename fetch_onboarding
202d52e 
Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com>
Signed-off-by: Victor <67214928+Victorsitou@users.noreply.github.com>
@shiftinv
chore: empty commit to hopefully fix github
ac805a5
@shiftinv shiftinv enabled auto-merge (squash) April 21, 2023 18:35
@shiftinv shiftinv merged commit f0ddf79 into DisnakeDev:master Apr 21, 2023
@shiftinv shiftinv removed the s: needs review Issue/PR is awaiting reviews label Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiftinv shiftinv shiftinv approved these changes

@onerandomusername onerandomusername Awaiting requested review from onerandomusername

Assignees
No one assigned
Labels
t: api support Support of Discord API features t: enhancement New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Victorsitou @shiftinv @onerandomusername