Skip to content

refactor: use absolute imports#1451

Open
onerandomusername wants to merge 2 commits intomasterfrom
qt/absolute-imports
Open

refactor: use absolute imports#1451
onerandomusername wants to merge 2 commits intomasterfrom
qt/absolute-imports

Conversation

@onerandomusername
Copy link
Member

Summary

feeler for whether absolute imports is worth it

@read-the-docs-community
Copy link

read-the-docs-community bot commented Oct 20, 2025

Documentation build overview

📚 disnake | 🛠️ Build #30032265 | 📁 Comparing 344f67d against latest (7c3b4f0)


🔍 Preview build

Show files changed (48 files in total): 📝 48 modified | ➕ 0 added | ➖ 0 deleted
File Status
index.html 📝 modified
whats_new.html 📝 modified
api/abc.html 📝 modified
api/activities.html 📝 modified
api/app_commands.html 📝 modified
api/app_info.html 📝 modified
api/audit_logs.html 📝 modified
api/automod.html 📝 modified
api/channels.html 📝 modified
api/clients.html 📝 modified
api/components.html 📝 modified
api/emoji.html 📝 modified
api/entitlements.html 📝 modified
api/events.html 📝 modified
api/exceptions.html 📝 modified
api/guild_scheduled_events.html 📝 modified
api/guilds.html 📝 modified
api/integrations.html 📝 modified
api/interactions.html 📝 modified
api/invites.html 📝 modified
api/localization.html 📝 modified
api/members.html 📝 modified
api/messages.html 📝 modified
api/misc.html 📝 modified
api/permissions.html 📝 modified
api/roles.html 📝 modified
api/skus.html 📝 modified
api/soundboard.html 📝 modified
api/stage_instances.html 📝 modified
api/stickers.html 📝 modified
api/subscriptions.html 📝 modified
api/ui.html 📝 modified
api/users.html 📝 modified
api/utilities.html 📝 modified
api/voice.html 📝 modified
api/webhooks.html 📝 modified
api/widgets.html 📝 modified
ext/tasks/index.html 📝 modified
ext/commands/api/app_commands.html 📝 modified
ext/commands/api/bots.html 📝 modified
ext/commands/api/checks.html 📝 modified
ext/commands/api/cogs.html 📝 modified
ext/commands/api/context.html 📝 modified
ext/commands/api/converters.html 📝 modified
ext/commands/api/exceptions.html 📝 modified
ext/commands/api/help_commands.html 📝 modified
ext/commands/api/misc.html 📝 modified
ext/commands/api/prefix_commands.html 📝 modified

@shiftinv
Copy link
Member

(also, for reference: #951)

@Sharp-Eyes
Copy link
Member

+1 from me, in any case

@Enegg
Copy link
Contributor

Enegg commented Oct 20, 2025

(also, for reference: #951)

In disnake.ext.*, imports from the main lib and ext previously were visually separated (by virtue of using absolute imports for the former); the new order is confusing

disnake.ext can be configured as forced separate, or we can configure custom import groups and order

@onerandomusername
Copy link
Member Author

(also, for reference: #951)

In disnake.ext.*, imports from the main lib and ext previously were visually separated (by virtue of using absolute imports for the former); the new order is confusing

disnake.ext can be configured as forced separate, or we can configure custom import groups and order

Already did that 😄

@Enegg
Copy link
Contributor

Enegg commented Oct 20, 2025

Fyi, there's also a python.analysis.importFormat pylance setting that controls how pylance auto-imports stuff, but it is set to "absolute" by default

@shiftinv shiftinv added the t: refactor/typing/lint Refactors, typing changes and/or linting changes label Oct 21, 2025
@onerandomusername onerandomusername marked this pull request as ready for review October 22, 2025 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t: refactor/typing/lint Refactors, typing changes and/or linting changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants